Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text_mining_targeted_association data and parser update #110

Closed
edgargaticaCU opened this issue Apr 19, 2023 · 12 comments
Closed

text_mining_targeted_association data and parser update #110

edgargaticaCU opened this issue Apr 19, 2023 · 12 comments
Assignees

Comments

@edgargaticaCU
Copy link

edgargaticaCU commented Apr 19, 2023

API URL: https://biothings.ncats.io/text_mining_targeted_association
Parser GitHub URL: https://github.com/UCDenver-ccp/text_mining_targeted_association
Git branch/commit: Master 74b3f26
No. Documents: 1,762,002
Structure of documents: Added sources property and fixed publications property

@edgargaticaCU
Copy link
Author

I can't assign anyone so I'll just tag @erikyao

@erikyao
Copy link
Contributor

erikyao commented Apr 19, 2023

@edgargaticaCU thank you for the information! Will keep you updated

@erikyao
Copy link
Contributor

erikyao commented Apr 19, 2023

Hi @edgargaticaCU, I found that we have a new field "source" on https://github.com/UCDenver-ccp/text_mining_targeted_association/blob/master/parser.py#L120, and I think we should add it to the targeted_mapping as well.

@colleenXu
Copy link

@edgargaticaCU doing my usual reminder that your SmartAPI yaml will most likely need updating.

Some things I can think of:

  • version
  • add response-mapping for TRAPI edge.sources data
  • do the operations need updating? I noticed that the number of documents have been changing when comparing this update to earlier ones...

@edgargaticaCU
Copy link
Author

@erikyao this has been added in commit e1c0d2d

@edgargaticaCU
Copy link
Author

@edgargaticaCU doing my usual reminder that your SmartAPI yaml will most likely need updating.

Some things I can think of:

  • version
  • add response-mapping for TRAPI edge.sources data
  • do the operations need updating? I noticed that the number of documents have been changing when comparing this update to earlier ones...

I have updated the YAML locally but am waiting to push the changes until the data have been updated (in case an issue prevents that from happening before the end of the day, I wouldn't want the SmartAPI yaml to reference a property that doesn't exist).
The operations have not changed because the underlying data hasn't changed; this is just an update to the representation. The change in number of documents from the last update is (most likely) because the response from Node Normalizer has changed, causing some nodes and their associated edges to be excluded.

@erikyao
Copy link
Contributor

erikyao commented Apr 21, 2023

@colleenXu @edgargaticaCU API updated!

@erikyao erikyao self-assigned this Apr 26, 2023
@edgargaticaCU
Copy link
Author

I'm commenting here, but let me know if it is better to create a new Issue for this.
Colleen pointed out that the resource_id was set incorrectly in the parser. I have fixed this in revision f4e73cd
Nothing else should have changed, since a new export was not necessary for this fix.

@erikyao
Copy link
Contributor

erikyao commented Apr 28, 2023

I'm commenting here, but let me know if it is better to create a new Issue for this.

Colleen pointed out that the resource_id was set incorrectly in the parser. I have fixed this in revision f4e73cd

Nothing else should have changed, since a new export was not necessary for this fix.

No worries. I'll re-deploy it tomorrow.

@erikyao
Copy link
Contributor

erikyao commented May 1, 2023

Hi @edgargaticaCU, we are experiencing some problem accessing our internal server. Will keep you updated when it's fixed.

@colleenXu
Copy link

colleenXu commented May 10, 2023

@erikyao Have things been addressed so this can be re-deployed? Once it is, we'll be ready for the final part of setting up BTE to ingest this API with TRAPI 1.4 source data formatting. Which is discussed here and here

@erikyao
Copy link
Contributor

erikyao commented May 10, 2023

@colleenXu updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants