Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTTPS for proxy ows (wps) services #48

Closed
cehbrecht opened this issue Feb 7, 2019 · 10 comments
Closed

Support HTTPS for proxy ows (wps) services #48

cehbrecht opened this issue Feb 7, 2019 · 10 comments

Comments

@cehbrecht
Copy link
Member

The current twitcher implementation fails for https services with self-signed certificates.

There is already a patch available which needs to be integrated:
Ouranosinc@b42e052

See also issue #46.

@cehbrecht cehbrecht added the bug label Feb 7, 2019
@cehbrecht
Copy link
Member Author

@tlvu @huard I try to integrate the patch from ouranos.

@cehbrecht cehbrecht added this to the 0.4.0 milestone Feb 11, 2019
@tlvu
Copy link

tlvu commented Feb 11, 2019

@cehbrecht FYI, I tried the patch from Francis in a full PAVICS deployment and it works.

@cehbrecht
Copy link
Member Author

@tlvu @huard what do you think about PR #55?

@huard
Copy link

huard commented Feb 12, 2019

I'm out of my depth, but looks good.

@cehbrecht
Copy link
Member Author

Well, I merge ... we can figure out later.

@cehbrecht
Copy link
Member Author

fixed by PR #55.

@tlvu
Copy link

tlvu commented Feb 12, 2019

@cehbrecht oops sorry, I didn't realized you wanted a PR review since I was not in the reviewer list. At my previous workplace, we were explicit in requesting review by adding the intended person(s) to the reviewers list.

@tlvu
Copy link

tlvu commented Feb 12, 2019

@cehbrecht wow patch is so different than the original patch ! Don't think I would be able to review either. Fun time ahead for merging the difference between this version of twitcher and the version in ouranosinc :(

@cehbrecht
Copy link
Member Author

@tlvu in the birdhouse patch the ssl_verify is a parameter in the service registry, so you can decide for each WPS service.

@tlvu
Copy link

tlvu commented Feb 12, 2019

@cehbrecht ah nice! Disabling SSL certificate verification only for those WPS services that are behind self-signed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants