Removed t3_int isr #147
Closed
Removed t3_int isr #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stylesuxx
reviewed
Jul 20, 2023
| @@ -691,8 +683,6 @@ comp_read_wrong_startup_jump: | |||
| sjmp comp_check_timeout ; Continue to look for good ones | |||
|
|
|||
| comp_read_wrong_extend_timeout: | |||
| clr Flag_Demag_Detected ; Clear demag detected flag | |||
There was a problem hiding this comment.
Why is it no longer necessary to clear the demag detection flag?
stylesuxx
approved these changes
Jul 20, 2023
In the previous t3 isr version when t3 expires it reloads the timer after a small delay. In this version we have to load the reload times directly into timer3 and also update the reload time to have a functionality as close as possible to previous version's one.
…ons problems because not processing interrups on time
damosvil
force-pushed
the
fix/avoid_t3_int
branch
from
9d82c15
to
debeb7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed t3 interrupt service routine to avoid wasting necessary CPU cycles
To be merged after https://github.com/bird-sanctuary/bluejay/tree/feature/dynamic_pwm