-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.3.0 Release -- Major refactor and stability branch #8
base: main
Are you sure you want to change the base?
Conversation
The current version of the pydev command is designed as a proof of concept, but isn't really extensible beyond my own personal preferences. The solution to that, as I see it, is to create a common API for all current and future supported environment managers to adhere to, which we can then use as an abstract base class for future environment managers to use.
2effff9
to
88edf4e
Compare
This may not be necessary, it appears that all of the 'local' pyenv versions are available in all testenvs. However, in an ideal world, this would allow us to run the tests associated with a specific manager in a specific environment only.
As I was starting to work with and reason about the API for devwrangler it occurred to me that we want things to be quiet by default. With that in mind, it made more sense to make verbose logging *opt-in* rather than allowing the 'quiet' flag to be *opt-out*.
It turns out that the old tmpdir fixture actually had a replacement using the pathlib.Path object just like I wanted, and I didn't have to create that fixture on my own. With that in mind, I can simplify things considerably.
Ultimately, this basic check ensures that the manager itself: 1. Works (i.e. actually creates a conda environment where we expect it to) 2. Provides access to a default Python once the environment is created
Codecov Report
@@ Coverage Diff @@
## main #8 +/- ##
==========================================
- Coverage 34.84% 31.78% -3.07%
==========================================
Files 3 9 +6
Lines 66 129 +63
Branches 10 18 +8
==========================================
+ Hits 23 41 +18
- Misses 43 87 +44
- Partials 0 1 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some notes
$ pydev | ||
$ pydev create | ||
$ pydev create --env venv | ||
$ pydev create --env conda | ||
$ pyenv configure | ||
$ pydev configure --editor vscode | ||
$ pydev configure --editor vscode --extras django,jinja2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a review comment
The current release (0.2.2) is a proof of concept that was mostly so I could prove that this was an idea that could work. Now that that's done and I've had a few people express interest, the work that needs to be done is to make this a more robust, workable system. I'll be updating the body here as needed, but this is going to be a release branch meant to contain the bulk of the major refactor that needs to happen to make this a stable, usable tool for most people.
To-do
conda
andvenv
/pip
based environmentsvenv
/pip
conda
pip
/venv
conda
~/.devwrangler
on unix-based systems)