Lint SVG from stdin #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the CLI to support providing an SVG on `stdin` [1]. The CLI will only do this when provided with the `--stdin` flag, I choose this design as it was the only reliable way of switching between files and stdin I could find. Despite the awkward diff, the CLI flow for files (i.e. if `--stdin` is not used) is unchanged. The stdin flow is based on [2] and just calls the JS API's `lintSource` function on the entire input. -- 1. https://nodejs.org/api/process.html#processstdin 2. https://nodejs.org/api/stream.html#readablereadsize
|
This is awesome, TY very much. |
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #81 - /cc @PaulRBerg
Extend the CLI to support providing an SVG on
stdin. The CLI will only do this when provided with the--stdinflag, I choose this design as it was the only reliable way of switching between files and stdin I could find.The stdin flow is based on the
Readabledocs and just calls the JS API'slintSourcefunction on the entire input.