Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused i18n strings #3860

Closed
arunasurya opened this issue Jan 6, 2020 · 4 comments
Closed

Remove unused i18n strings #3860

arunasurya opened this issue Jan 6, 2020 · 4 comments
Assignees

Comments

@arunasurya
Copy link
Contributor

It seems like this string is no longer referenced from the source code, so we should remove it (see the link below). It creates confusion for translators who think that it should be translated. We should probably review the strings to check that there are no unused ones in general to save unnecessary work for translators.

portfolio.pending.support.text.getHelp.arbitrator=If you have any problems you can try to contact the trade peer in the trade \
  chat or ask the Bisq community at https://bisq.community. \
  If your issue still isn't resolved, you can request more help from an arbitrator.

portfolio.pending.support.text.getHelp.arbitrator=If you have any problems you can try to contact the trade peer in the trade \

@ripcurlx
Copy link
Contributor

I'll run a check for all translations to remove every key that is not used anymore.

@ripcurlx ripcurlx self-assigned this Jan 28, 2020
@niyid
Copy link
Contributor

niyid commented Feb 1, 2020

@ripcurlx
I had been unsure of the status (priority/importance) of this issue since it was listed for so long with no decoration. If you have not done it already, you may reassign to me.

@stale
Copy link

stale bot commented May 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented May 9, 2020

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants