Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting trade history to CSV has incorrect fee values #4207

Closed
dextertd opened this issue Apr 29, 2020 · 1 comment · Fixed by #4256
Closed

Exporting trade history to CSV has incorrect fee values #4207

dextertd opened this issue Apr 29, 2020 · 1 comment · Fixed by #4256

Comments

@dextertd
Copy link

Description

Exporting the trade history CSV using the EXPORT TO CSV button in PORTFOLIO -> HISTORY produces incorrect fee values ("Transaction Fee" and "Maker Fee").

Version

1.3.2

Steps to reproduce

See description.

Expected behaviour

EXPORT TO CSV creates a CSV with correct values for columns "Transaction Fee" and "Maker Fee".

Actual behaviour

EXPORT TO CSV creates a CSV with incorrect values for columns "Transaction Fee" and "Maker Fee". For example, my CSV says Transaction Fee: 0.00006080; Maker fee: 0.00043750; but that trade's JSON data is "txFee": 6560, "makerFee": 36. The fees for this trade were paid in BSQ.

Screenshots

Device or machine

Linux Mint 19.3 Tricia x86_64
MATE

Additional info

@ghost
Copy link

ghost commented May 12, 2020

  • Maker Fee : This is sometimes displaying the counterparty's trading fee. In addition to fixing the logic about displaying the correct fee, it should be renamed to Trading Fee since the user is not always maker.
  • txFee : it is sometimes displaying the counterparty's txFee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant