payment.amazonGiftCard.info = Inconsistent with wiki about Message Field

[Liisachan]

Description

In \core\src\main\resources\i18n\displayStrings.properties (and its translations), payment.amazonGiftCard.info states: “you must include the trade ID in the gift card''s message field. Please see the wiki”.

In https://bisq.wiki/Amazon_eGift_card#Step_2._Customize_eGift_card however, it is said that the Message field should be left blank.

This can confuse the user as to whether or not they should include the trade ID there. Maybe writing the ID there is usually not necessary nor desirable...?

It's not really a bug - more like a documentation issue.

Version

v1.7.3

[pazza83]

I removed the reference from the image.

I cannot find any other reference to trade ID on the page.

Let me know if I have missed anything.

[Liisachan]

Sorry if I was not clear. I'm talking about source code:

bisq/core/src/main/resources/i18n/displayStrings.properties

Line 3542 in 4849988

Bisq will show the BTC seller''s email address or phone number where the gift card should be sent, and you must include the trade ID in the gift \

[pazza83]

Hi @m52go are you able to remove this from Bisq source code?

[Liisachan]

Maybe not just removing, but explicitly advising the user not to say anything about btc there? While sending a gift card to your friend is perfectly legal, commonly done by millions of amazon users, it may be safer to keep a low profile to avoid unwanted attentions...?

[ripcurlx]

Maybe not just removing, but explicitly advising the user not to say anything about btc there? While sending a gift card to your friend is perfectly legal, commonly done by millions of amazon users, it may be safer to keep a low profile to avoid unwanted attentions...?

Good catch! I think just removing the trade id reference should be fine as during the trade this is mentioned explicitly anyways.

bisq/core/src/main/resources/i18n/displayStrings.properties

Lines 657 to 659 in 4849988

	portfolio.pending.step2_buyer.refTextWarn=Important: when making the payment, leave the \"reason for payment\" field \
	empty. DO NOT put the trade ID or any other text like 'bitcoin', 'BTC', or 'Bisq'. \
	You are free to discuss via trader chat if an alternate \"reason for payment\" would be suitable to you both.

[ripcurlx]

I just checked the remaining payment methods and only found it for halcash which is fine as there it is sent via text message.