Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract pricenode subproject to dedicated repository #5837

Closed
cbeams opened this issue Nov 16, 2021 · 5 comments
Closed

Extract pricenode subproject to dedicated repository #5837

cbeams opened this issue Nov 16, 2021 · 5 comments
Assignees

Comments

@cbeams
Copy link
Contributor

cbeams commented Nov 16, 2021

For the reasons discussed at #5824 (comment).

Note that a bisq-pricenode repository already exists and may be un-archived and wiped (or deleted and re-created) for this purpose.

Will need to think about:

  • Process, documentation, sysctl / docker config changes for @bisq-network/pricenode-operators
  • Versioning
  • Cleaning up no-longer used dependencies from the gradle/verification-metadata.xml file introduced in Upgrade to Gradle 7.3 #5824. These entries won't be deleted by default, so must remember to do it manually after the extraction is complete.
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Apr 28, 2022

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@cbeams
Copy link
Contributor Author

cbeams commented Jul 31, 2022

Update: the work to extract the pricenode has now been done by @ghubstan and others. See https://github.com/bisq-network/bisq-pricenode.

@ghubstan
Copy link
Contributor

Update: the work to extract the pricenode has now been done by @ghubstan and others. See https://github.com/bisq-network/bisq-pricenode.

Thanks, @cbeams . I might hand the new bisq-pricenode off to OPS / @Emzy this week. Extracting the monitor is almost ready, but I want to fix some problems in it before trying to give it to OPS. Inventory is done. Other repo extractions should be quick and easy.

I will remove bisq :subprojects after hand-off to OPS.

@wiz
Copy link
Contributor

wiz commented Jul 31, 2022

I forgot to tell you guys but we implemented a whole price server from scratch into the @mempool project a while back, it queries multiple exchanges for multiple currencies etc. so we would just need to implement the same bisq API spec into the mempool backend and bisq could drop the bisq-pricenode entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants