Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use Bisq as a full DAO node with Bitcoin Core 28.1 - Might be related to BuyerVerifiesPreparedDelayedPayoutTx Exception error #7389

Open
Akira45-0 opened this issue Feb 11, 2025 · 3 comments

Comments

@Akira45-0
Copy link

Akira45-0 commented Feb 11, 2025

Description

With Bitcoin Core 28.1, Bisq 1.9.19 synchronizes the DAO forever and produces errors when it's run as a full DAO node (with --fullDaoNode=true option)

Version

1.9.19

Steps to reproduce

Run Bitcoin Core 28.1, run Bisq 1.9.19

Expected behaviour

Bisq should synchronize the DAO correctly when running as a full DAO node with Bitcoin Core 28.1.

Actual behaviour

In the logs Bisq produces the following error:

Feb-11 17:19:44.744 [RpcService] INFO  b.c.d.n.f.RpcService: Starting RpcService on 127.0.0.1:8332 with user ***, listening for blocknotify on port 5120 from 127.0.0.1 

Feb-11 17:19:44.994 [RpcService] DEBUG c.g.j.JsonRpcHttpClient: Request {"id":"87943630","jsonrpc":"2.0","method":"getnetworkinfo","params":[]} 

Feb-11 17:19:45.023 [RpcService] DEBUG c.g.j.JsonRpcHttpClient: JSON-RPC Response: {"jsonrpc":"2.0","result":{"version":280100,"subversion":"/Satoshi:28.1.0/","protocolversion":70016,"localservices":"0000000000000c0d","localservicesnames":["NETWORK","BLOOM","WITNESS","NETWORK_LIMITED","P2P_V2"],"localrelay":true,"timeoffset":0,"networkactive":true,"connections":11,"connections_in":1,"connections_out":10,"networks":[{"name":"ipv4","limited":false,"reachable":true,"proxy":"","proxy_randomize_credentials":false},{"name":"ipv6","limited":false,"reachable":true,"proxy":"","proxy_randomize_credentials":false},{"name":"onion","limited":true,"reachable":false,"proxy":"","proxy_randomize_credentials":false},{"name":"i2p","limited":true,"reachable":false,"proxy":"","proxy_randomize_credentials":false},{"name":"cjdns","limited":true,"reachable":false,"proxy":"","proxy_randomize_credentials":false}],"relayfee":1.0E-5,"incrementalfee":1.0E-5,"localaddresses":[],"warnings":[]},"id":"87943630"} 

Feb-11 17:19:45.084 [RpcService] ERROR b.c.d.n.f.RpcService: com.fasterxml.jackson.databind.exc.MismatchedInputException: Cannot deserialize value of type `java.lang.String` from Array value (token `JsonToken.START_ARRAY`)
 at [Source: UNKNOWN; byte offset: #UNKNOWN] (through reference chain: bisq.core.dao.node.full.rpc.dto.DtoNetworkInfo["warnings"])

Bisq will never synchronize the DAO. It will be stuck with the "Synchronizing DAO" information on the status bar forever.

Screenshots

Image

Device or machine

Linux Mint 22.1

Additional info

Downgrading Bitcoin Core to 27.2 makes everything work apparently fine, with the exception of the following warning message:
Feb-11 18:04:11.242 [RpcService] WARN b.c.d.n.f.RpcService: Server version mismatch - client optimized for '[0.18.0 .. 0.22.1)', node responded with '0.27.2'

Bisq should work fine with the latest Bitcoin Core version. As of now, it is 28.1.

Bisq should not force users to use old Bitcoin Core versions with known security vulnerabilities, like the version 22.1 (a rollback of 17 versions, of which 6 were major).

I would also like to point out that this problem may be related to failed trades that kept occurring with the BuyerVerifiesPreparedDelayedPayoutTx Exception error when I had been using Bitcoin Core 28 with a lite DAO Bisq node, of which examples can be found here:
bisq-network/support#1773
bisq-network/support#1772
bisq-network/support#1771
bisq-network/support#1768
bisq-network/support#1765
bisq-network/support#1764
bisq-network/support#1762
bisq-network/support#1761
bisq-network/support#1760
bisq-network/support#1757
and so on.

@HenrikJannsen
Copy link
Collaborator

HenrikJannsen commented Feb 13, 2025

Seems the RPC API has been changed.

The warning was added when the RPC code was implemented. We have not discovered since issues with new Bitoin versions. So it seem its just the 0.28 update which broke things.

@Akira45-0
Copy link
Author

Thank you. If this issue is not going to be fixed because of the maintenance mode of Bisq 1, then I think that Bisq BTC nodes should not use Bitcoin Core v28 (I think the two run by @suddenwhipvapor do use v28) and it would be beneficial to put somewhere a warning not to use v28 with Bisq 1.

@Akira45-0
Copy link
Author

Akira45-0 commented Feb 13, 2025

Seems the RPC API has been changed.

Image

bitcoin/bitcoin#27101

Image

Image

As of now, the two Bisq BTC nodes that used Core v28 have been downgraded to v27.2 thanks to suddenwhipvapor. Let's hope it will mitigate the failed trades problem, at least for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants