Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JPackager on Windows fails #1383

Closed
HenrikJannsen opened this issue Nov 15, 2023 · 3 comments
Closed

JPackager on Windows fails #1383

HenrikJannsen opened this issue Nov 15, 2023 · 3 comments
Assignees
@alvasw
Labels
bug Something isn't working build-system
Milestone
2.0.0

Comments

@HenrikJannsen
Copy link
Contributor

HenrikJannsen commented Nov 15, 2023 •
edited
Loading

For building a binary on Windows WiX 3.0 or later is needed. This requires .net to be installed as well.
To get .net running it requires to turn .net on in the features settings.
I could get the jpackager with wix running but it failed (Win11). Seems some wix resources are missing. The installer in the temp dir could be opened and installed bisq, but when opening bisq I got "failed to launch jvm".
@HenrikJannsen
Copy link
Contributor Author

HenrikJannsen commented Nov 15, 2023 •
edited
Loading

@alvasw FYI

@HenrikJannsen HenrikJannsen added this to the 2.0.0 milestone Nov 15, 2023
@HenrikJannsen HenrikJannsen changed the title JPackager on Windows fails due missing wixtoolset JPackager on Windows fails Nov 15, 2023
@HenrikJannsen HenrikJannsen added the bug Something isn't working label Nov 15, 2023
This was referenced Nov 17, 2023
Merged
Closed
@HenrikJannsen
Copy link
Contributor Author

@alvasw Is Windows packager already working and was it tested?

@HenrikJannsen HenrikJannsen mentioned this issue Dec 15, 2023
Closed
@HenrikJannsen
Copy link
Contributor Author

Packager task works on Windows but there are small issues open with icon and title for notifications.
See #1411 (comment)

I will close that issue as those open issues are covered by #1411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alvasw alvasw

Labels
bug Something isn't working build-system
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@alvasw @HenrikJannsen