Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle fixes and improvements #178

Closed
2 of 5 tasks
alkum opened this issue Mar 30, 2022 · 5 comments
Closed
2 of 5 tasks

Gradle fixes and improvements #178

alkum opened this issue Mar 30, 2022 · 5 comments
Assignees

Comments

@alkum
Copy link
Contributor

alkum commented Mar 30, 2022

This is an "umbrella task" for various gradle-related fixes and improvements:

I plan to address the above with small incremental PRs, to simplify reviews and to detect potential issues early.

@chimp1984
Copy link
Contributor

Can you also have a look if binary build for JavaFx is working? It had issues when we started with the setup.

@alkum alkum self-assigned this Mar 30, 2022
@alkum
Copy link
Contributor Author

alkum commented Mar 30, 2022

Can you also have a look if binary build for JavaFx is working? It had issues when we started with the setup.

You mean integrating and using https://gluonhq.com/products/javafx/ ?

@chimp1984
Copy link
Contributor

is JavaFx now a product of Gluon? I just mean to create a binary as we do in Bisq 1. Java packager had issues with our java version as far I remember.

@alkum
Copy link
Contributor Author

alkum commented Apr 2, 2022

AFAIK JavaFX packaging was tricky, it only worked with the Bisq 1 packager because the openjdk version used also included the JavaFX modules and OS-native libraries.

I can look into it again and see if things changed.

@chimp1984
Copy link
Contributor

I guess that is superseeded by the improvements @alvasw did over the past weekss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants