-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle fixes and improvements #178
Comments
Can you also have a look if binary build for JavaFx is working? It had issues when we started with the setup. |
You mean integrating and using https://gluonhq.com/products/javafx/ ? |
is JavaFx now a product of Gluon? I just mean to create a binary as we do in Bisq 1. Java packager had issues with our java version as far I remember. |
AFAIK JavaFX packaging was tricky, it only worked with the Bisq 1 packager because the openjdk version used also included the JavaFX modules and OS-native libraries. I can look into it again and see if things changed. |
I guess that is superseeded by the improvements @alvasw did over the past weekss. |
This is an "umbrella task" for various gradle-related fixes and improvements:
gradle/libs.versions.toml
platforms/common-platform/build.gradle
(constraints not being enforced?)ResolutionStrategy
in https://docs.gradle.org/current/dsl/org.gradle.api.artifacts.ResolutionStrategy.htmlI plan to address the above with small incremental PRs, to simplify reviews and to detect potential issues early.
The text was updated successfully, but these errors were encountered: