follow established conventions for Tor integration

[adrelanos]

Bisq seems to take quite a unique approach to Tor integration, not following any established conventions. Therefore making things difficult down the line and incompatible with Tor based operating systems such as Whonix and perhaps Tails.

issues:

• It is currently not possible to use Bisq with an already installed system Tor?
• Bisq cannot be with a Tor that is already running on a different computer (or virtual machine)?
• Add Whonix 17 Support #1894

old issues fixed in git:

• Bisq even used to parse Tor's log file. Just mentioning this to show that invented solutions without looking at the exiting conventions and talking to the Tor community, complex things will be implemented, incompatible, causing later issues, requiring refactoring.

Notes:

• Tor over Tor should be prevented. (reasons: adversarial for anonymity, bad for performance, see Refrain from "Tor over Tor" Scenarios)

What are the conventions? See:

• Tor: https://gitlab.torproject.org/legacy/trac/-/wikis/doc/Tor_friendly_applications_best_practices
• Whonix: https://www.whonix.org/wiki/Dev/Project_friendly_applications_best_practices

Full disclosure: I am a developer of Whonix.

[sk757a]

With the current implementation, it is impossible to connect to the network from countries with restrictions. I need to be able to use my own Tor configuration or a standalone Tor instance.

[HenrikJannsen]

Here is a PR implementing support for connecting to an external Tor process: #3046

@sk757a
One can pass JVM arguments to add any torrc entries.
For instance to set ControlPort 127.0.0.1:9051 you have to pass:
-Dapplication.network.configByTransportType.tor.torrcOverrides.ControlPort=127.0.0.1:9051

See https://github.com/bisq-network/bisq2/blob/main/docs/dev/build.md how to pass JVM args to the Bisq application.