-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For Cycle 34 #1027
Comments
As dev team lead I approve this compensation request for dev. It would be great if you could approve/reject your own test scenarios on bisq.ontestpad as well, so it is easier for me to see how detail which parts have been tested in one glance. |
can absolutely do @ripcurlx , yet can you please explain what you mean, as I didn't quite understand? On testpad, I make sure to tag the tested sections, and in every one of them also attach screenshots of the tested feature + link to PR, example: The link to the pastebin wall of text is to have a better ordered resume of what I actually did, that's what I personally feel would be clearer for me at a glance, and my personal "flight sheet" when I do testing, so I thought I would include it :) |
@w0000000t I didn't know that you already did this 👍 I think for test cases that are a pass you don't need to add extra information (of course appreciated), but for fail ones it is good to link the Github issue in the bug tracking field (screenshots will be there anyway I guess). Before I release and/or I start my release testing I review an overview which is similar to this report screen: https://bisq.ontestpad.com/project/1/folder/f153/report/?auth=b91656669a12abf05a9583ff8dbcb213 to see which sections need extra test coverage from my side and who tested what. So when one or two trusted contributors test certain sections I assume that this was tested properly (I normally have tested most of the code changes anyways during a PR review myself). |
@ripcurlx I guess I like to make myself accountable, since I'm requesting a compensation, and I attach screenshots to show that I actually did the testing, instead of simply clicking on boxes saying that I did ;) As of now I feel like doing this little extra work, I understand now though how you check "at a glance", and I'll keep doing the pastebin thing for my own convenience and link it in CR if that's okay with you, since my testing is reported on testpad for your checking I believe 👍 |
My Team Lead review is complete and I approve this request. Please submit your DAO proposal and paste the transaction ID here as a comment when complete, thanks. |
96cb71a5f2034da95219a0ba3cd389a1167bbfb1417db13f59b9efb496fac53b |
Issuance by Team:
Total Issuance: 577.24 BSQ (equivalent to: 710.00 USD) |
Closed as accepted. |
Summary
[577.24]
Contributions delivered
Contributions in progress
In case it is of interest, I can further improve this script and implement a web page on Tor where support agents can login to add their own reports, and have stats be compiled automatically at the end of the cycle
The text was updated successfully, but these errors were encountered: