Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 57 #1518

Closed
alvasw opened this issue Mar 29, 2024 · 5 comments
Closed

For Cycle 57 #1518

alvasw opened this issue Mar 29, 2024 · 5 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@alvasw
Copy link

alvasw commented Mar 29, 2024

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 7075.47
  • USD requested: 15000
  • BSQ rate: 2.12 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 56 #1489

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
bisq: PR Review bisq-network/bisq#7004 dev bisq-network/bisq#7004

Nit

Please squash your commits and change the commit message to something like "Fix Code Comment Typos" or "Fix Typos in Code Comments". You can find our guide on how to write commit messages here: https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md#write-well-formed-commit-messages .

bisq: PR Review bisq-network/bisq#7012 dev bisq-network/bisq#7012

Nit

getdaostatus is missing in the /bisq-cli --helpoutput.

---------

ACK

Tested:

  • bisq-cli --help
  • bisq-cli getdaostatus --help
  • bisq-cli getdaostatus
  • Rate Limiting
bisq: PR Review bisq-network/bisq#7016 dev bisq-network/bisq#7016

NACK

All BSQ Altcoin offers stay online, can be taken, and funds stay locked.

Test Scenario

  1. Create legacy BSQ Altcoin accounts for Alice and Bob on v1.9.14
  2. Create BSQ Altcoin offers on Alice's client
  3. Update Alice's client to PR code
  4. Take Alice's BSQ Altcoin offer from Bob's (v1.9.14) client
  5. Alice's shows "offer was taken" UI and both parties can complete trade as usual
bisq: PR Review bisq-network/bisq#7023 dev bisq-network/bisq#7023

Nit

I know that someone else wrote the original code but we should try to clean up existing code when working on it. We can avoid the redudant copying of the trade list by using Collections.unmodifiableList(getObservableList()).

Apart from that I aggree with dutu. API consumers should be able to tell whether a trade failed.

---------

utACK

bisq: PR Review bisq-network/bisq#7035 dev bisq-network/bisq#7035

utACK

DAO hashes match with my nodes too.

bisq: PR Review bisq-network/bisq#7036 dev bisq-network/bisq#7036

Nit

We can simplify the null and isEmpty handling with Optional<String>s. Moreover Optionals enforce us to handle both cases and avoid NullPointerExceptions.

bisq: PR Review bisq-network/bisq#7041 dev bisq-network/bisq#7041

utACK

wiz Thank you very much for running everything over the last years!

bisq: PR Review bisq-network/bisq#7047 dev bisq-network/bisq#7047

utACK

Thank you!

bisq: AsyncFileWriter: Truncate before write dev bisq-network/bisq#7039
bisq: persistence: Implement Rolling Backups dev bisq-network/bisq#7040
bisq2: Update alvasw's pubkey dev bisq-network/bisq2#1746
bisq2: Generate Desktop App Fat Jar dev bisq-network/bisq2#1767

Fixes #1764

bisq2: Bump version number to 2.0.1 dev bisq-network/bisq2#1803
bisq2: Test Tor Installation and Startup Race Condition dev bisq-network/bisq2#1910

Ref: #1798

bisq2: Implement directory monitoring flow components dev bisq-network/bisq2#1911

Consumers can asynchronously subscribe to directory events with the Flow components.

Ref: #1798

Changes:

bisq2: Implement Flow-component-based DirectoryWatcher dev bisq-network/bisq2#1912

Ref: #1798

bisq2: Extract LdPreload computation out of TorProcess dev bisq-network/bisq2#1913
bisq2: tor: Implement ControlPortFileParser dev bisq-network/bisq2#1914

Presently, we parse Tor's log file to detect when the control port is ready. This is unstable and could break with any Tor update. A better approach is to use Tor's 'ControlPortWriteToFile' config option and parse the control port from that file.

Ref: #1798

bisq2: tor: Implement ControlPortReadyWaiter dev bisq-network/bisq2#1915

Use the flow-component-based DirectoryWatcher to wait for the control port file and parse the control port file with the ControlPortFileParser afterward.

Ref: #1798

dev 15000 Total for items above.
@ghost
Copy link

ghost commented Mar 29, 2024

Info

Read BSQ amount from summary: 7075.47
Read USD amount from summary: 15000
Read BSQ rate from summary: 2.12
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}

Errors

ERROR: Total USD does not match the sum of line items:

  • Summary total: 15000.00 USD
  • Calculated total: 0.00 USD

@ghost ghost added parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team and removed parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid labels Mar 29, 2024
@alvasw
Copy link
Author

alvasw commented Mar 29, 2024

I am sorry for the late request. This cycle has been hectic and extremely stressful.

@alvasw
Copy link
Author

alvasw commented Mar 29, 2024

c325b0b95d47ceae66834645de428d438c9ad27bd59a1cea99941fab32b38306

@MwithM MwithM added this to the Cycle 57 milestone Mar 29, 2024
@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Apr 10, 2024
@ghost
Copy link

ghost commented Apr 10, 2024

Issuance by Team:

team amount BSQ amount USD
dev 7075.47 15000.00

Total Issuance: 7075.47 BSQ (equivalent to: 15000.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Apr 10, 2024

Closed as accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

3 participants