Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 65 #1685

Open
alvasw opened this issue Dec 12, 2024 · 1 comment
Open

For Cycle 65 #1685

alvasw opened this issue Dec 12, 2024 · 1 comment
Milestone

Comments

@alvasw
Copy link

alvasw commented Dec 12, 2024

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 8823.53
  • USD requested: 15000
  • BSQ rate: 1.70 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 64 #1660

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
bisq: PR Review bisq-network/bisq#7318 dev bisq-network/bisq#7318

utACK

bisq: core: Implement RegtestWalletAppKit dev bisq-network/bisq#7290

The RegtestWalletAppKit sets up BitcoinJ and loads the given wallets.

bisq: bitcoind: Target commit 6737755 dev bisq-network/bisq#7291
bisq: core: Add dependency to bitcoind:regtest (integration source set) dev bisq-network/bisq#7292
bisq: core: Implement sendBsqTest dev bisq-network/bisq#7293

First, the sendBsq test creates one BTC and two BSQ wallets. Afterward,
it funds the BTC and one BSQ wallet with 1 BTC. Next, the funded BSQ
wallet sends 100 BSQ to the second BSQ wallet.

bisq: sendBsq: Throw InsufficientMoneyException when BSQ balance too low dev bisq-network/bisq#7294

We should throw an InsufficientMoneyException when the CoinSelection
gathered amount is lower than the amount the user wants to send.

bisq: BsqWalletV2Test: Add invalid and dust send tests dev bisq-network/bisq#7295

The tests try to send 0 BSQ and the current dust amount in BSQ.

bisq: BtcNetworkConfig: Shuffle Bitcoin Core peers dev bisq-network/bisq#7297

We try to connect to the first 7 Bitcoin Core nodes always in the same
order. Only if connections to these nodes fail we look further into the
list. This change shuffles the node addresses before passing them to
BitcoinJ thus removing the bias from the first 7 prioritized nodes.

bisq: FeedbackWindow: Fix double wording from PR #7120 dev bisq-network/bisq#7303
bisq: Fix duplicates in BtcNode list dev bisq-network/bisq#7304

When the user uses our federated BTC nodes, we merge the hard-coded
nodes with the ones provided by the filter. The hard-coded node's
operator field is set to the node's operator and operator field of the
nodes from the filter is set to "Provided by filter". When the same BTC
node is in the hard-coded list and the filter, Bisq adds both to the
merged list because the operator field is different.

This change explicitly marks the onionAddress, hostName, address, and
port field to be used in the hashCode and equals implementation.

bisq: BtcNode: Make port field final dev bisq-network/bisq#7305
bisq: Move federated BTC node selection to FederatedBtcNodeProvider dev bisq-network/bisq#7306
bisq: Pass nodes instead of BtcNodes class to FederatedBtcNodeProvider dev bisq-network/bisq#7307
bisq: Add FederatedBtcNodeProviderTest.onlyHardcodedNodes test dev bisq-network/bisq#7308
bisq: BtcNodes: Fix hostname parsing dev bisq-network/bisq#7309

The fromFullAddress method parsed hostnames as IPV4 addresses instead as
hostnames.

bisq: NodeAddress: Fix broken IPV6 parsing dev bisq-network/bisq#7310

Bisq accepts IPV6 node addresses but the NodeAddress can't parse them.

bisq: BtcNodeProvider: Fix BTC node banning dev bisq-network/bisq#7311

The FederatedBtcNodeProvider compared the list of banned nodes with each
BtcNode's hostname instead of checking a BtcNode's hostname, ip address,
and onion address.

bisq: FederatedBtcNodeProvider: Compare banned node address and port dev bisq-network/bisq#7312
bisq: BitcoinjRegtestSetup: Implement wallet funding dev bisq-network/bisq#7319

The fundWallet method sends the given amount to the BitcoinJ wallet from
the Bitcoin Core miner wallet, mines one block, and waits until the
BitcoinJ wallet updates its wallet balance.

bisq: Add send BSQ from empty wallet test dev bisq-network/bisq#7320
bisq: Add send more BSQ than in wallet test dev bisq-network/bisq#7321
bisq: RegtestWalletAppKit: Implement createNewBsqWallet method dev bisq-network/bisq#7322

The createNewBsqWallet method creates a new BitcoinJ wallet and
registers it with BitcoinJ's BlockChain and PeerGroup.

bisq: BitcoinjBsqTests: Create per test BSQ wallet dev bisq-network/bisq#7323

At the moment, some tests are sharing the same BSQ wallets. This change
creates a separate wallet for indenpendent tests to improve the tests's
reliability.

dev 15000 Total for items above.
@alvasw
Copy link
Author

alvasw commented Dec 12, 2024

858c17e826d5f9f66b78a4feb976f177a457d9bff73baed1e417de42df48fdcc

@MwithM MwithM added this to the Cycle 65 milestone Dec 12, 2024
@MwithM MwithM moved this to In Review in Compensation Request Board Dec 12, 2024
@MwithM MwithM moved this from In Review to Proposal Submitted in Compensation Request Board Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Proposal Submitted
Development

No branches or pull requests

2 participants