Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For Cycle 19 #726

Closed
stejbac opened this issue Nov 27, 2020 · 5 comments
Closed

For Cycle 19 #726

stejbac opened this issue Nov 27, 2020 · 5 comments
Assignees
@ripcurlx
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone
Cycle 19

Comments

@stejbac
Copy link

stejbac commented Nov 27, 2020 •
edited
Loading

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 2985.07
  • USD requested: 2000
  • BSQ rate: 0.67 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 17 #672

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Fix remaining blackmail vulnerabilities dev 2000 bisq-network/bisq#4789 There are a few separate trade protocol security issues allowing creation of an incorrect deposit tx / delayed payout tx addressed by this (which weren't all fixable prior to the SegWit upgrade), necessitating a forced update for 1.5.0

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

Title Team USD Link Notes
Add taker check for deposit amount dev 0 bisq-network/bisq#4860 This is a cleaner patch for a potential security issue which should already be prevented by earlier changes

I also submitted a proposal for a possible way to improve wallet security (and later add wallet 2FA):

Additionally, I have been commenting on the proposal bisq-network/proposals#279, regarding the possible use of some cryptography techniques to reduce the size of the deposit tx (+ later spends) further.
@stejbac stejbac changed the title [WIP] For Cycle 19 For Cycle 19 Nov 27, 2020
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Nov 27, 2020
@chimp1984
Copy link

Thanks @stejbac for your valueable contribution!!!

@MwithM MwithM added this to the Cycle 19 milestone Nov 27, 2020
@ripcurlx
Copy link
Contributor

As team lead I approve this request. Please submit your DAO proposal and paste the transaction ID here as a comment when complete, thanks.

@stejbac
Copy link
Author

stejbac commented Nov 30, 2020

Tx ID: 56ed387fd20a58873c010660b9620c75b9f10c82267e32fe4a60ed9e71b31c67

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Dec 9, 2020
@ghost
Copy link

ghost commented Dec 9, 2020

Issuance by Team:

team amount BSQ amount USD
dev 2985.07 2000.00

Total Issuance: 2985.07 BSQ (equivalent to: 2000.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Dec 9, 2020

Closed as accepted.

@MwithM MwithM closed this as completed Dec 9, 2020
@stejbac stejbac mentioned this issue Jan 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ripcurlx ripcurlx

Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Compensation Request Board
Archived in project
Milestone
Cycle 19
Development

No branches or pull requests
4 participants
@ripcurlx @MwithM @chimp1984 @stejbac