Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit pull request reviews using GitHub's "Review changes" button #7

Open
cbeams opened this issue Mar 20, 2018 · 0 comments
Open

Comments

@cbeams
Copy link
Contributor

cbeams commented Mar 20, 2018

When reviewing a pull request, do not just add a normal comment, but actually click the "Review changes" button and add your summary using the ACK / NACK language at #6.

This makes it easier for everyone to see that a review has already been submitted for a given pull request without having to scroll through comments, makes it possible to search for pull requests without reviews, pull requests reviewed by a certain user, etc. It also makes the review comment itself that much more prominent, because it shows up with a big green checkmark, red X.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant