Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2023.05 protocol upgrade]. Reject future transaction versions #121

Open
tomFlowee opened this issue Mar 13, 2024 · 0 comments
Open

[2023.05 protocol upgrade]. Reject future transaction versions #121

tomFlowee opened this issue Mar 13, 2024 · 0 comments

Comments

@tomFlowee
Copy link

The 2023 protocol upgrade had a transaction-version rule that was added to consensus. (CHIP).

The unrealized side-effect is that there is a good chance that in the future we might see a new, incompatible transaction format. The point is, a future transaction version may work fine with todays codebase, it may not. There is no way to know.

So, if someone runs todays version of libauth (or any application that incorporates it) unexpected things may happen.

This issue is to suggest that libauth's raw transaction processing code will refuse to process transactions that have a too-high version number. Forcing people that get those transactions to upgrade to a newer version of libauth that presumably has added support. And to avoid them getting bad results that may happen due to parsing unknown transaction type.

The transactions-in-mainchain research showed that there are no transactions with versions higher than 9 in testnet4 and mainchain (all bets are off for testnet3). Therefor I suggest rejecting all transactions greater-equal 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant