Merge #330: Add proper versioning to About page

fbb7f77 qml: add proper versioning to About page (jarolrod)

Pull request description:

  | master | pr |
  | ------ | -- |
  | <img width="752" alt="Screen Shot 2023-04-21 at 10 38 19 PM" src="https://user-images.githubusercontent.com/23396902/233757650-e213dbba-2856-410e-b6e7-a57317739c27.png"> | <img width="752" alt="Screen Shot 2023-04-21 at 10 36 18 PM" src="https://user-images.githubusercontent.com/23396902/233757661-258b3a6d-abd2-44ab-a3b0-a85052ca43e4.png"> |

  [![Windows](https://img.shields.io/badge/OS-Windows-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/unsecure_win_gui.zip?branch=pull/<PR>)
  [![Intel macOS](https://img.shields.io/badge/OS-Intel%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/unsecure_mac_gui.zip?branch=pull/<PR>)
  [![Apple Silicon macOS](https://img.shields.io/badge/OS-Apple%20Silicon%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/unsecure_mac_arm64_gui.zip?branch=pull/<PR>)
  [![ARM64 Android](https://img.shields.io/badge/OS-Android-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/unsecure_android_apk.zip?branch=pull/<PR>)

ACKs for top commit:
  hebasto:
    ACK fbb7f77, tested on Ubuntu 23.04.

Tree-SHA512: a83b47973c7ce418e8d8861af41ad2908a28e3e811d044a4bfcd6d8d1b369bffa8f39f95243e31924c9d78159cf22ece4a80b67c9a087a95d9658ae2ebeddd8f

Author: hebasto

src/qml/components/AboutOptions.qml

@@ -51,7 +51,7 @@ ColumnLayout {
         header: qsTr("Version")
         actionItem: ExternalLink {
             parentState: versionLink.state
-            description: "v22.99.0-1e7564eca8a6"
+            description: nodeModel.fullClientVersion
             link: "https://bitcoin.org/en/download"
             iconSource: "image://images/caret-right"
             iconWidth: 18

src/qml/nodemodel.h

@@ -7,10 +7,12 @@
 
 #include <interfaces/handler.h>
 #include <interfaces/node.h>
+#include <clientversion.h>
 
 #include <memory>
 
 #include <QObject>
+#include <QString>
 
 QT_BEGIN_NAMESPACE
 class QTimerEvent;
@@ -25,6 +27,7 @@ class NodeModel : public QObject
 {
     Q_OBJECT
     Q_PROPERTY(int blockTipHeight READ blockTipHeight NOTIFY blockTipHeightChanged)
+    Q_PROPERTY(QString fullClientVersion READ fullClientVersion CONSTANT)
     Q_PROPERTY(int numOutboundPeers READ numOutboundPeers NOTIFY numOutboundPeersChanged)
     Q_PROPERTY(int maxNumOutboundPeers READ maxNumOutboundPeers CONSTANT)
     Q_PROPERTY(int remainingSyncTime READ remainingSyncTime NOTIFY remainingSyncTimeChanged)
@@ -36,6 +39,7 @@ class NodeModel : public QObject
 
     int blockTipHeight() const { return m_block_tip_height; }
     void setBlockTipHeight(int new_height);
+    QString fullClientVersion() const { return QString::fromStdString(FormatFullVersion()); }
     int numOutboundPeers() const { return m_num_outbound_peers; }
     void setNumOutboundPeers(int new_num);
     int maxNumOutboundPeers() const { return m_max_num_outbound_peers; }