Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy Icon Tooltip Text #111

Closed
Rspigler opened this issue Oct 24, 2020 · 3 comments
Closed

Proxy Icon Tooltip Text #111

Rspigler opened this issue Oct 24, 2020 · 3 comments

Comments

@Rspigler
Copy link
Contributor

The Proxy Icon appears when a proxy is set up. I believe the icon only shows if there are no clearnet connections. (I unfortunately cannot test this right now because I do not have control of my firewall settings where I am and cannot set an incoming clearnet connection). But maybe, the icon shows regardless of other connections? (If so, that should be another discussion).

Please see #86 (comment) for the discussion.

My point being, maybe we should change the Proxy Icon Tooltip Text from "Proxy is enabled" to something like "Connections are currently behind a Proxy" - like I think we will be doing for the Tor Icon Tooltip Text.

The use case is for something like if proxy=127.0.0.1:9050 and listen=1 is set (against default), but clearnet incoming connections have not been made yet. We wouldn't want users to think that, although the connections are currently marked secure, that they will forever be secured.

See #110 for an issue for better configuration of the settings.

@Rspigler
Copy link
Contributor Author

Further conversations have taken discussion towards icons/GUI switches indicating current&future status, which I believe is better as well.

@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@Rspigler and others