Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Signer can be enabled even when external signer script is not set #395

Closed
jarolrod opened this issue Aug 4, 2021 · 1 comment · Fixed by #396
Closed

External Signer can be enabled even when external signer script is not set #395

jarolrod opened this issue Aug 4, 2021 · 1 comment · Fixed by #396
Labels
Bug Something isn't working UX All about "how to get things done" Wallet

Comments

@jarolrod
Copy link
Member

jarolrod commented Aug 4, 2021

The External Signer option when creating a wallet is supposed to be disabled while the external signer script has not been set in settings. There is a way to enable this option even though the script has not been set, then if you were to create an External Signer wallet the gui will crash because the external signer script was never set:

terminate called after throwing an instance of 'std::runtime_error'
  what():  GetExternalSigner: restart bitcoind with -signer=<cmd>
Aborted (core dumped)

Steps to reproduce:

No special preparation. Just required that the external signer script has not be set in settings. This is to ensure that proper functionality is that the External Signer script option is supposed to be disabled.

  1. Go to create a new wallet
  2. Notice that the External Signer option is disabled, as it is supposed to be
  3. Select, then de-select Encrypt Wallet
  4. The External Signer option is now enabled, when it is not supposed to be
  5. Select the now enabled External Signer option and create wallet
  6. GUI will crash
@jarolrod jarolrod added the Bug Something isn't working label Aug 4, 2021
@hebasto hebasto added UX All about "how to get things done" Wallet labels Aug 4, 2021
@Rspigler
Copy link
Contributor

Rspigler commented Aug 6, 2021

When you say:

The External Signer option is disabled

do you mean the External Signer script path remains empty, or is there some other option I am missing?

@hebasto hebasto closed this as completed in 03826ae Aug 6, 2021
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working UX All about "how to get things done" Wallet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants