Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net, gui: -upnp option -- "override" vs "can be changed on-the-fly" #710

Open
fanquake opened this issue Feb 7, 2023 · 0 comments
Open

Comments

@fanquake
Copy link
Member

fanquake commented Feb 7, 2023

Moved from bitcoin/bitcoin#18184.

On master (68e841e) the -upnp option being set in the command line or in the configuration file overrides the GUI option only on startup.

If a user (un)checks the "Map port using UPnP" checkbox in the "Network" tab of the "Options" window, the client does not take into account the fact that the -upnp option is set in the command line or in the configuration file.

There some ways to resolve an issue:

  • document the current behavior
  • deactivate the "Map port using UPnP" checkbox if the -upnp option is set in the command line or in the configuration file
  • smth else

The brainstorm question is which way is the best?


This issue was initially raised by luke-jr in his review of #18077.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant