Merge #41: Ignore clang's self-assignment check

7045a90 Ignore clang's self-assignment check (Cory Fields)

Pull request description:

  As-documented in the code, this is already safe so ignore the false-positive.

  Necessary to turn on the option in bitcoin/bitcoin#30234. Passes tests there.

ACKs for top commit:
  maflcko:
    ACK 7045a90

Tree-SHA512: 7afa7d4e170e84f022fde037f4de6e417ad08bbc0e3953f1f3ea88da41cda1cc913a70ce43d4f6973813e78b0a0a97238deb44f79b6089688094b1e27ed69e51

Author: fanquake

include/leveldb/status.h

@@ -103,6 +103,8 @@ class LEVELDB_EXPORT Status {
 inline Status::Status(const Status& rhs) {
   state_ = (rhs.state_ == nullptr) ? nullptr : CopyState(rhs.state_);
 }
+
+// NOLINTBEGIN(bugprone-unhandled-self-assignment)
 inline Status& Status::operator=(const Status& rhs) {
   // The following condition catches both aliasing (when this == &rhs),
   // and the common case where both rhs and *this are ok.
@@ -112,6 +114,8 @@ inline Status& Status::operator=(const Status& rhs) {
   }
   return *this;
 }
+// NOLINTEND(bugprone-unhandled-self-assignment)
+
 inline Status& Status::operator=(Status&& rhs) noexcept {
   std::swap(state_, rhs.state_);
   return *this;