Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

naming: privkey vs seckey #670

Closed
real-or-random opened this issue Oct 9, 2019 · 3 comments
Closed

naming: privkey vs seckey #670

real-or-random opened this issue Oct 9, 2019 · 3 comments

Comments

@real-or-random
Copy link
Contributor

We have a bunch of secp256k1_ec_privkey_ functions but then we have secp256k1_ec_seckey_verify. I think we should create a privkey alias for this function.

More generally, we sometimes write "private key" and sometimes "secret key", and all the privkey functions expect a seckey argument. This should be made consistent too.

@kroggen
Copy link

kroggen commented Oct 11, 2019

What about using the privkey as default and let the seckey as the alias? So the function names are consistent.

My vote goes to have the arguments named privkey too. Decreasing the amount of different names makes the code easier to understand.

@jonasnick
Copy link
Contributor

The thing is called seckey everywhere except the ec_privkey function names. So let's keep that as a default.

@real-or-random
Copy link
Contributor Author

Superseded by #671

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants