This repository has been archived by the owner on Oct 21, 2024. It is now read-only.
feat(BUX-120): initializes repository with architecure #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wregulski
changed the title
dorzepowski
reviewed
Jul 20, 2023
| } | ||
| } | ||
|
|
||
| func (c *compositeBroadcaster) BestQuote(ctx context.Context, feeCategory, feeType string) error { |
There was a problem hiding this comment.
Something to consider:
Maybe we should always return something like Result struct, that apart from the Response from Arc will also contain status of the call: I mean something containing informations like:
Arc 1 - call fail with error
Arc 2 - call finished with success + using response as a result
Arc 3 - skipped
Overall - success
There was a problem hiding this comment.
Ok, we can go this way - this response is mocked but I will think about it when implementing.
Co-authored-by: Damian Orzepowski <damian.orzepowski@softwarelab.com.pl>
arkadiuszos4chain
approved these changes
Jul 20, 2023
dorzepowski
approved these changes
Jul 20, 2023
wregulski
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.