This repository has been archived by the owner on Oct 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
fix: return submit errors with context information #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-4chain
reviewed
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally I really like this approach :)
My thoughts:
- I found another place where is might be wrapped as you proposed: function
parseArcError
. - I'm only wondering, how the indentations will be parsed/treated by log collecting apps like elasticsearch/kibana.
dorzepowski
reviewed
Feb 2, 2024
Nazarii-4chain
previously approved these changes
Feb 2, 2024
dorzepowski
previously approved these changes
Feb 6, 2024
chris-4chain
reviewed
Feb 6, 2024
arkadiuszos4chain
dismissed stale reviews from dorzepowski and Nazarii-4chain
via
February 6, 2024 06:37
3aa89ff
chris-4chain
approved these changes
Feb 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation returns misleading error messages from
SubmitTx
eg:which suggests Arc node responded with the error.
Proposed solution formats message and extends error information with context:
Pull Request Checklist