Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUDIT failure due to bdk + cbf dependency rocksdb #119

Closed
rajarshimaitra opened this issue Sep 12, 2022 · 1 comment · Fixed by #125
Closed

AUDIT failure due to bdk + cbf dependency rocksdb #119

rajarshimaitra opened this issue Sep 12, 2022 · 1 comment · Fixed by #125
Assignees

Comments

@rajarshimaitra
Copy link
Contributor

This is to document the recent cargo-audit failures happening in CI.

$ cargo-audit audit
    Fetching advisory database from `https://github.com/RustSec/advisory-db.git`
      Loaded 456 security advisories (from /home/raj/.cargo/advisory-db)
    Updating crates.io index
    Scanning Cargo.lock for vulnerabilities (280 crate dependencies)
Crate:         rocksdb
Version:       0.14.0
Title:         Out-of-bounds read when opening multiple column families with TTL
Date:          2022-05-11
ID:            RUSTSEC-2022-0046
URL:           https://rustsec.org/advisories/RUSTSEC-2022-0046
Solution:      Upgrade to >=0.19.0
Dependency tree: 
rocksdb 0.14.0
└── bdk 0.22.0
    ├── bdk-reserves 0.22.0
    │   └── bdk-cli 0.5.0
    └── bdk-cli 0.5.0

Crate:         ansi_term
Version:       0.12.1
Warning:       unmaintained
Title:         ansi_term is Unmaintained
Date:          2021-08-18
ID:            RUSTSEC-2021-0139
URL:           https://rustsec.org/advisories/RUSTSEC-2021-0139
Dependency tree: 
ansi_term 0.12.1
└── clap 2.34.0
    └── structopt 0.3.26
        └── bdk-cli 0.5.0

Crate:         stdweb
Version:       0.4.20
Warning:       unmaintained
Title:         stdweb is unmaintained
Date:          2020-05-04
ID:            RUSTSEC-2020-0056
URL:           https://rustsec.org/advisories/RUSTSEC-2020-0056
Dependency tree: 
stdweb 0.4.20
└── time 0.2.27
    ├── cookie_store 0.12.0
    │   └── ureq 1.5.5
    └── cookie 0.14.4
        ├── ureq 1.5.5
        └── cookie_store 0.12.0

error: 1 vulnerability found!
warning: 2 allowed warnings found

There is a vulnerability in rocksdb which was originally reported by @afilini here bitcoindevkit/bdk#724.

Depending on the outcome of experimentation with nakamoto for cbf, we might be able to get rid of rocksdb fully from our dep tree.

Till then I guess we have to live with this audit failure?

Or we can disable compact_filters temporarily in bdk-cli..

@notmandatory notmandatory moved this to Todo in BDK-CLI Roadmap Sep 13, 2022
@notmandatory notmandatory changed the title AUDIT Failure AUDIT Failure due to bdk + cbf dependency rocksdb Sep 13, 2022
@notmandatory notmandatory changed the title AUDIT Failure due to bdk + cbf dependency rocksdb AUDIT failure due to bdk + cbf dependency rocksdb Sep 13, 2022
@notmandatory notmandatory added this to the Release 0.7.0 milestone Sep 28, 2022
@notmandatory
Copy link
Member

I support temporarily removing compact_filters support to resolve this audit issue.

@rajarshimaitra rajarshimaitra linked a pull request Oct 30, 2022 that will close this issue
3 tasks
@notmandatory notmandatory modified the milestone: Release 0.7.0 Nov 11, 2022
@rajarshimaitra rajarshimaitra self-assigned this Nov 22, 2022
@rajarshimaitra rajarshimaitra moved this from Todo to In Progress in BDK-CLI Roadmap Nov 22, 2022
@github-project-automation github-project-automation bot moved this from In Progress to Done in BDK-CLI Roadmap Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants