Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement basic spending policy APIs #80

Closed
notmandatory opened this issue Nov 12, 2021 · 4 comments
Closed

Implement basic spending policy APIs #80

notmandatory opened this issue Nov 12, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@notmandatory
Copy link
Member

notmandatory commented Nov 12, 2021

Description

Add or update APIs in bdk-ffi to support basic spending policy features. Also test the new APIs by updating bdk-kotlin or bdk-swift to use the new and updated APIs. See "Spending Policy Demo" for bdk-cli based example usage.

APIs include:

  1. Giving a wallet, return Policy structure (as Dictionary?) for "external" and "internal" descriptors.
  2. When creating a transaction PSBT, specify the "external policy" to use

Expected Outcomes

  • Update bdk.udl and lib.rs with functions and structs as needed
  • Update bdk-kotlin or bdk-swift and add tests to cover new spending policy functionality

Resources

Skills Required

Mentor(s)

@artfuldev @notmandatory

Difficulty

Medium

Competency Test (optional)

  • Install rust, compile bdk-ffi and build and test bdk-swift or bdk-kotlin.
  • Read through the BDK docs.
  • Use bdk-cli to walk through the "Spending Policy Demo"
  • Install and run example bdk-kotlin or bdk-swift example wallet.
  • Familiarity with basic rust, should be able to write basic structs and functions.
@notmandatory notmandatory added this to the Stackmate Core Support milestone Nov 12, 2021
@notmandatory notmandatory added the enhancement New feature or request label Nov 12, 2021
@notmandatory notmandatory modified the milestones: 0.3.0, 0.4.0 Feb 2, 2022
@notmandatory notmandatory added the summer-of-bitcoin Summer of Bitcoin Project label Feb 3, 2022
@notmandatory notmandatory moved this to Todo in BDK-Bindings Feb 14, 2022
@thunderbiscuit thunderbiscuit removed the summer-of-bitcoin Summer of Bitcoin Project label Jul 19, 2023
@thunderbiscuit
Copy link
Member

This issue might need an update, as I think the Policy module in bdk will be replaced by the policy module in miniscript.

@notmandatory
Copy link
Member Author

For 1.0 I don't expect the policy features in bdk to change much. The current plan is to introduce the new "planning module" features in the 2.0 milestone.

@LLFourn
Copy link

LLFourn commented Dec 5, 2023

I would not implement policy.rs api because of this change FWIW.

@artfuldev artfuldev removed their assignment Jan 26, 2024
This was referenced Apr 9, 2024
@coderabbitai coderabbitai bot mentioned this issue Apr 25, 2024
8 tasks
@thunderbiscuit
Copy link
Member

This feature was requested and added in the 1.0 release by #612.

@github-project-automation github-project-automation bot moved this from Todo to Done in BDK-Bindings Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

4 participants