Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/0.28 audit failing due to RUSTSEC-2022-0046.html #1006

Closed
notmandatory opened this issue Jun 16, 2023 · 1 comment · Fixed by #1007
Closed

release/0.28 audit failing due to RUSTSEC-2022-0046.html #1006

notmandatory opened this issue Jun 16, 2023 · 1 comment · Fixed by #1007
Labels
bug Something isn't working
Milestone

Comments

@notmandatory
Copy link
Member

notmandatory commented Jun 16, 2023

Describe the bug

For some reason the CI audit just caught that there is an issue with rocksdb due to "Out-of-bounds read when opening multiple column families with TTL". See:

https://rustsec.org/advisories/RUSTSEC-2022-0046.html

To Reproduce

cargo update
cargo audit

Expected behavior

Should not fail audit tests.

Build environment

  • BDK tag/commit: release/0.28
  • OS+version: any
  • Rust/Cargo version: ci tests against 1.57.0 and 1.65.0
  • Rust/Cargo target: any

Additional context

The rocksdb dependency is only used when the compact_filters feature is enabled. The reason we haven't update our rocksdb version earlier is that newer versions don't support our MSRV of 1.57. See also #480.

I propose we disable the audit warning for this issue since compact_filters is an experimental feature and we don't use the rocksdb "multiple column families with TTL" feature mentioned in this advisory.

@notmandatory notmandatory added the bug Something isn't working label Jun 16, 2023
@notmandatory notmandatory added this to the 0.28.1 milestone Jun 16, 2023
@notmandatory notmandatory moved this to Todo in BDK Maintenance Jun 16, 2023
@nondiremanuel nondiremanuel moved this from Todo to In Progress in BDK Maintenance Jun 17, 2023
@notmandatory
Copy link
Member Author

fixed by #1007

@github-project-automation github-project-automation bot moved this from In Progress to Done in BDK Maintenance Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant