Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace bdk_tmp_plan with miniscript planning api #1068

Open
LLFourn opened this issue Aug 9, 2023 · 0 comments
Open

Replace bdk_tmp_plan with miniscript planning api #1068

LLFourn opened this issue Aug 9, 2023 · 0 comments
Labels
module-wallet new feature New feature or request

Comments

@LLFourn
Copy link
Contributor

LLFourn commented Aug 9, 2023

@danielabrozzoni looks like she's gotten rust-bitcoin/rust-miniscript#481 (comment) to a good place. It would be helpful if we could replace what we currently use for this role with that PR.

There was a very outdated attempt at doing this by @afilini here: https://github.com/LLFourn/bdk_core_staging/pull/66/files#diff-c14cb78dacd186a4264416678c250c834363aadab6cb8d1657709ffc970ca9ffR469

This has the important sign_with_keymap whose logic needs to go somewhere probably but maybe there might be some state of the art in rust-bitcoin or rust-miniscript to help with the signing part.

The goal of this PR is to make a github dependency on that PR and see how we can use it in the existing examples that use bdk_tmp_plan.

@nondiremanuel nondiremanuel added this to the 1.0.0-alpha.3 milestone Aug 15, 2023
@nondiremanuel nondiremanuel removed this from BDK Aug 15, 2023
@notmandatory notmandatory added this to BDK Nov 13, 2023
@notmandatory notmandatory moved this to Todo in BDK Nov 13, 2023
@notmandatory notmandatory added the new feature New feature or request label Nov 13, 2023
@notmandatory notmandatory removed this from the 2.0.0 milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module-wallet new feature New feature or request
Projects
Status: Todo
Development

No branches or pull requests

3 participants