Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DIY logger #1222

Closed
notmandatory opened this issue Nov 16, 2023 · 4 comments
Closed

Add DIY logger #1222

notmandatory opened this issue Nov 16, 2023 · 4 comments
Labels
dependencies Pull requests that update a dependency file
Milestone

Comments

@notmandatory
Copy link
Member

notmandatory commented Nov 16, 2023

          Should we open an issue to introduce some sort of diy logger as ldk does?

Originally posted by @danielabrozzoni in #1204 (comment)

@notmandatory notmandatory added this to BDK Nov 16, 2023
@notmandatory notmandatory moved this to Todo in BDK Nov 16, 2023
@notmandatory notmandatory added this to the 1.0.0-beta.0 milestone Nov 16, 2023
@notmandatory
Copy link
Member Author

Added this issue as a placeholder. It's not part of the user API so can do it at any time.

@LLFourn
Copy link
Contributor

LLFourn commented Nov 30, 2023

My take is that our architecture doesn't require logging. We no longer have any long running processes occurring in bdk itself. You could do logging in the blockchain crates for example but that can be decided on a crate by crate basis.

@notmandatory notmandatory added the dependencies Pull requests that update a dependency file label Mar 18, 2024
@notmandatory notmandatory moved this from Todo to Done in BDK Mar 18, 2024
@notmandatory
Copy link
Member Author

Closing this issue since we only depend on the log crate in examples, not in any of the lib crates.

@LLFourn
Copy link
Contributor

LLFourn commented Mar 28, 2024

(might be a nice idea to remove log from the examples. You can just use println! in examples)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

No branches or pull requests

2 participants