Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lighting's special feerates #608

Closed
TheBlueMatt opened this issue May 21, 2022 · 1 comment · Fixed by #678
Closed

Support lighting's special feerates #608

TheBlueMatt opened this issue May 21, 2022 · 1 comment · Fixed by #678
Assignees
Labels
new feature New feature or request

Comments

@TheBlueMatt
Copy link

Lightning is a special snowflake and does fees in satoshis per 1000-weight-units. It'd be nice if BDK supported that, and while we're at it maybe satoshis per 1000-vbytes, which also seems to be missing.

One concern with lightning, that doesn't appear to be handled in the BDK feerate logic is that rounding can push below the bitcoin core 1 sat/vbyte limit, so lightning actually requires a minimum of 253 sats-per-1000-weight. I'm not sure how best to capture this dozen in the BDK API, but I guess just being careful when calculating the concrete fee.

@vladimirfomene
Copy link
Contributor

@notmandatory , let me take this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants