-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report progress on blockchains that don't currently report intermediate progress #798
Comments
FWIW the plan is to remove This effectively allows you to get a callback any time a new address is consumed by them. Of course not all blockchain data is fetched in the same way but for those that iterate over script pubkeys and find related transactions this is a very convenient way. |
Thanks, make sense not to change anything now then, but I will leave this issue open as a place holder to create example code to demo now to do this once we have the |
Describe the enhancement
Blockchains electrum and esplora don't currently update the progress callback. For apps that expect progress this causes a problem. The blockchains that don't report progress should just call the progress call back with 0 and then 100 when done.
Use case
On apps that let the user select which blockchain there needs to be at least starting and ending progress call backs even if the underlying blockchain doesn't have intermediate progress updates.
Additional context
bdk/src/blockchain/electrum.rs
Line 121 in 5c42102
bdk/src/blockchain/esplora/blocking.rs
Line 121 in 5c42102
bdk/src/blockchain/esplora/async.rs
Line 139 in 5c42102
The text was updated successfully, but these errors were encountered: