-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust-esplora-client
shouldn't introduce an async runtime
#102
Comments
Please note how ridiculous the dependency tree (which in a Bitcoin context should always also be read as 'increased security risk') is that
|
Thanks for raising the issue @tnull |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #98, a dependency on the
async_std
runtime was introduced. IIUC, this was done only to use itssleep
method.I don't think
rust-esplora-client
should make choices regarding which async runtime users should use. If anything, it should be using the by now defaulttokio
rather thanasync_std
.I believe I already brought this up in the discussion of the precursor #71, which however seems now gone for some reason.
An alternative to pulling in an extra dependency for this would simply be to have the user specify a
sleep
callback function that would use whatever sleep functionality they have available in their runtime.(cc @notmandatory @ValuedMammal)
The text was updated successfully, but these errors were encountered: