Product Feedback v2

[aassoiants]

Great work team!

I did test using Windows Brave. And mobile Brave.

Mobile Page

• Too much empty space between first and second value props
  

• Let's please remove or blur out the location in the left lightning image

Search Page

• When i click out of a selected source when AND when there is nothing searched (t.i., only after choosing something from the search bar drop down), it returns me to the homepage at the same scroll that i was on in the search page. Not anchored to the above the scroll as it should be. (Doesn't happen on mobile)
  https://github.com/bitcoinsearch/bitcoinsearch-app/assets/126297088/5908cbee-3dc2-445b-9ada-83e1a6934dab

• The applied filters don't follow English capitalization formatting (Both mobile & desktop)
  

• The Sources list seems like it's not left-justified. "Bitcoin Dev Mailing List Archive" seems like it's a space further to the left compared to others. (Only desktop)
  

• Clicking the logo button to get the homescreen took a second longer than it should have. See if you can replicate.

• The screen kind of moves around when toggling between the "suggest a source" feature and existing it (look at the header). (Only desktop).
  https://github.com/bitcoinsearch/bitcoinsearch-app/assets/126297088/437204fa-78be-4022-b11c-965015df001c

[Emmanuel-Develops]

When i click out of a selected source when AND when there is nothing searched (t.i., only after choosing something from the search bar drop down), it returns me to the homepage at the same scroll that i was on in the search page. Not anchored to the above the scroll as it should be. (Doesn't happen on mobile)

I made selecting filters on desktop stay in place because the filters and results are side by side, whereas for mobile selecting a filter moves to results page and then it wouldn't be a good ux to keep user mid scroll.

Looking at it now all filters should scroll to the top because its new data and you want users aware these are new results.

Oh and for what you experienced, this applies to homepage as well. As when there's no query params (search, filter or sort) we just swap the results page for homepage.

FIXED in 5d423d5

[Extheoisah]

The screen kind of moves around when toggling between the "suggest a source" feature and existing it (look at the header). (Only desktop).

I think its because when the modal comes into focus and the background is out of focus, the scrollbar is hidden which leaves more room for the header to expand. But on modal close, the scrollbar is visible and takes the usual space. I don't think this issue should be a blocker.

[Emmanuel-Develops]

Let's please remove or blur out the location in the left lightning image

paper is working on this

[Emmanuel-Develops]

Clicking the logo button to get the homescreen took a second longer than it should have. See if you can replicate.

@aassoiants you're nitpicking! 👀
I wrote an optimization for this some days back so I'm surprised there's an issue at all. I can't replicate it, can you record a video please

The screen kind of moves around when toggling between the "suggest a source" feature and existing it (look at the header). (Only desktop).

As Theo said, the modal causes the scrollbar to be hidden, hence extra space and the header expands to fill that space. It doesn't show up on mac tho because of native mac scrollbar behavior.

[aassoiants]

@aassoiants you're nitpicking! 👀 I wrote an optimization for this some days back so I'm surprised there's an issue at all. I can't replicate it, can you record a video please

Haha eagle eyes! Don't worry if can't repli.

As Theo said, the modal causes the scrollbar to be hidden, hence extra space and the header expands to fill that space. It doesn't show up on mac tho because of native mac scrollbar behavior.

If this takes more than a day to solve, then put to post-launch please

[Emmanuel-Develops]

If this takes more than a day to solve, then put to post-launch please

I've been on chat for a while, this issue is a bit niche and hard to test as it only shows up in Windows. Let's move it post-launch.

[adamjonas]

Some questions...

On https://bitcoinsearch-app-git-fix-filterdomai-bc4eff-btc-knowledge-base.vercel.app/?filter_domain=https%3A%2F%2Flists.linuxfoundation.org%2Fpipermail%2Fbitcoin-dev%2F&filter_authors=Ava+Chow

The rolled up replies are only Ava Chow. Should we be showing all replies to the post she authored or is this expected?

---

Can't read the BDP on dark mode:

---

Can't see this image on dark mode

The entire box describing chat should be linked rather than that tiny text. Also should the pagination be full width or centered?

---

Can we make this pull down longer so I don't have to scroll?

[aassoiants]

Thanks @adamjonas!

Questions

• Can't see this image on dark mode
  Do you mean the image doesn't have an outline?
  

Do Now

• Can't read the BDP on dark mode. Replicated. Should be same font as cards below it.
  
• The entire box describing chat should be linked rather than that tiny text.
  
• Can we make this pull down longer so I don't have to scroll? Not replicated, great find!
  

Do Later

• Exploration: What to Display When Selecting an Author and They Have Children Replies #120
• UI: Centre-align the pagination #121

[aassoiants]

A few obsies on Brave. Desktop. Windows.

• No serp card description/ copy for (only?) bitcoinops topics.
  
  

• Unsure what the difference is between "Bitcoin Dev Mailing List" vs "Bitcoin Dev Mailing List Archive" vs "Bitcoin Dev Mailing List Active"
  

• I don't think the drop-down options should exist when a user's on the Search UI/ Search page. The purpose of the dropdown is enabling discovery for newer users and light education about how the product works.
  

[Emmanuel-Develops]

No serp card description/ copy for (only?) bitcoinops topics.

Its an issue with the scraping, I think andreas is looking into it cc: @kouloumos

Unsure what the difference is between "Bitcoin Dev Mailing List" vs "Bitcoin Dev Mailing List Archive" vs "Bitcoin Dev Mailing List Active"

"Bitcoin Dev Mailing List" -> mailing-list.bitcoindevs.xyz (our google groups list)
"Bitcoin Dev Mailing List Archive" -> list linux foundation
"Bitcoin Dev Mailing List Active" -> gnusha google groups

@urvishp80 replaced the domain gnusha domain with ours on the index, seems a recent scraper reintroduced the gnusha domain back, given that the earliest appearance is 11th May.

I don't think the drop-down options should exist when a user's on the Search UI/ Search page.

I'm indifferent about it, but you make a solid case.

edit: The PR bitcoinsearch/scraper#64 fixes the 2 scraping issues

[kouloumos]

Unsure what the difference is between "Bitcoin Dev Mailing List" vs "Bitcoin Dev Mailing List Archive" vs "Bitcoin Dev Mailing List Active"

@Emmanuel-Develops can you explain (or point to the relevant code) how we come up with

Bitcoin Dev Mailing List" vs "Bitcoin Dev Mailing List Archive" vs "Bitcoin Dev Mailing List Active"

is this something that comes directly from elasticsearch?

Everything should be called "Bitcoin Dev Mailing List" on the frontend. If this needs to be fixed in elasticsearch-index level then we should call them all the same at that level. The urls show the actual source (archive, active, _) but that's not something that concerns the user when searching on Bitcoin Search. @urvishp80 has more context on that.

[Emmanuel-Develops]

@Emmanuel-Develops can you explain (or point to the relevant code) how we come up with

@kouloumos
This was done during the transition from gnusha to our google groups domain (mailing-list.bitcoindevs.xyz).
Its basically a mapping on the FE
Here:

bitcoinsearch-app/src/config/mapping.json

Line 5 in fe14f45

"https://lists.linuxfoundation.org/pipermail/bitcoin-dev/": "Bitcoin Dev mailing list archive",

bitcoinsearch-app/src/config/mapping.json

Lines 63 to 64 in fe14f45

	"https://gnusha.org/pi/bitcoindev/": "Bitcoin Dev mailing list active",
	"https://mailing-list.bitcoindevs.xyz/bitcoindev/": "Bitcoin Dev mailing list"

is this something that comes directly from elasticsearch?

No it is not, it comes from the mapping.json shown above.

They can't all be "Bitcoin Dev Mailing List" because the ES index returns both the archive lists.linux... and active mailing-list.bitcoindevs.xyz... from queries.
Users will see duplicated "Bitcoin Dev Mailing List" when sorting by domain and won't be able to tell archive and active apart.

The index is meant to map gnusha.. to mailing-list.bitcoindevs.xyz.. and @urvishp80 is doing that in the current open PR on scraper, here:
https://github.com/bitcoinsearch/scraper/blob/41d616f264c9acf09e226aeea03fd9bffd9fcde2/mailing-list/main.py#L17-L18
and he replaces the domain here
https://github.com/bitcoinsearch/scraper/blob/41d616f264c9acf09e226aeea03fd9bffd9fcde2/mailing-list/main.py#L192

[urvishp80]

Based on chat with @adamjonas, I updated the scraper (related to bitcoin-dev) code as follows:

1. changed the value of domain field for all the docs:

• from https://gnusha.org/pi/bitcoindev/ to https://mailing-list.bitcoindevs.xyz/bitcoindev/
• keep https://lists.linuxfoundation.org/pipermail/bitcoin-dev/ and https://lists.linuxfoundation.org/pipermail/lightning-dev/ as it is

However, as the PR has not been merged yet. Here are the counts for the docs in the Elasticsearch Index for the given domain:

• https://gnusha.org/pi/bitcoindev/ = 44 (latest docs as PR has not been merged)

• https://mailing-list.bitcoindevs.xyz/bitcoindev/ = 255 (updated manually using Elasticsearch Dev Console a few days back)

• https://lists.linuxfoundation.org/pipermail/lightning-dev/ = 4970 (keeping the domain as it is)

• https://lists.linuxfoundation.org/pipermail/bitcoin-dev/ = 24504 (keeping the domain as it is)

Here is the message from @Emmanuel-Develops regarding the Frontend.