Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaged version of brotli is affected by CVE-2020-8927 #45

Open
insanitybit opened this issue Dec 20, 2021 · 2 comments
Open

Packaged version of brotli is affected by CVE-2020-8927 #45

insanitybit opened this issue Dec 20, 2021 · 2 comments

Comments

@insanitybit
Copy link

insanitybit commented Dec 20, 2021

Brotli versions prior 1.0.8 are affected by CVE-2020-8927.

https://www.cvedetails.com/cve/CVE-2020-8927/

This is an integer overflow and I believe it is reachable from the rust bindings, but that's just based on a quick perusal of the source code.

I'm currently working on a PR to add an advisory to the rustsec adivsorydb as well.

rustsec/advisory-db#1124

This was referenced Dec 22, 2021
@ruuda
Copy link

ruuda commented Oct 16, 2022

A simple solution is to not vendor Brotli, but to link against a system-provided libbrotli instead, which can be kept up to date independently, and requires no code changes in the Rust code to update. For an example, see ruuda@ec1c87e.

@DoumanAsh
Copy link

JFYI
I keep maintained bindings to brotli https://crates.io/crates/compu-brotli-sys/1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants