Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug ux] The stalled AO recovery modal disappears with a simple click #823

Closed
pointops opened this issue Mar 9, 2023 · 3 comments
Closed

Comments

@pointops
Copy link

pointops commented Mar 9, 2023

3.31.4 stable

Once the Non-Active Orders modal is displayed due to Honey re-connect, if the user clicks anywhere outside the panel itself it closes.

Recovery.modal.mp4

As a consequence, the opportunity to relaunch the AO is lost completely. The modal won't come back even after a reload of the application.

suggestion

a) only close the modal with the [x] button
b) do not deselect the [history] by any-click either
c) allow 'editing' historical orders (copy their parameters to create a new AO) - revive.

@pm-bfx
Copy link

pm-bfx commented Mar 9, 2023

Hi @pointops ,

agreed on a) -> for 3.31.5

regarding b) you mean that the checkboxes before the orders can only change status if the user explicitly clicks on them? if so agreed.

regarding c) I'm sorry could you elaborate? you mean adding the possibility to edit - in situ - the AOs that were recovered before submitting the modal?

@pointops
Copy link
Author

Sorry for the delay.

For b) and c) I had slightly different in mind.

B: kindly see #825. What you suggest in the comment above would be a retrograde step for me (if I understood correctly).

C: kindly see #826.

@github-actions
Copy link

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants