Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot delete locally subscription already deleted remotely #1021

Closed
2 tasks done
p1gp1g opened this issue Sep 16, 2024 · 4 comments
Closed
2 tasks done

Cannot delete locally subscription already deleted remotely #1021

p1gp1g opened this issue Sep 16, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@p1gp1g
Copy link

p1gp1g commented Sep 16, 2024

Problem scope

  • I'm sure that this is a DAVx⁵ problem.

App version

  • I'm using the latest available DAVx⁵ version.

Android version and device/firmware type

Android 14/GOS

Steps to reproduce

  1. Create a new calendar with task list
  2. Sync with DAVx5
  3. Delete on the server the calendar
  4. When you try to delete the subscription on DAVx5, it receives a 404 and fail

When the DELETE request receives a 404, it should consider the request as completed and delete the local subscription

Actual result

When the DELETE request is send, it receives a 404 response. The UI show a warning that "An HTTP error has occurred", and the debug information says that "the requested resource doesn't exist (anymore)"

Expected result

When the DELETE request receives a 404, it should consider the request as completed and delete the local collection

Further info

No response

@p1gp1g p1gp1g added the bug Something isn't working label Sep 16, 2024
@p1gp1g
Copy link
Author

p1gp1g commented Sep 16, 2024

Doing a "refresh list" fixes the issue. Maybe it is worth doing it automatically when it receives the 404 ?

@rfc2822 rfc2822 added enhancement New feature or request and removed bug Something isn't working labels Sep 16, 2024
@rfc2822
Copy link
Member

rfc2822 commented Sep 16, 2024

Doing a "refresh list" fixes the issue.

Yes, that's how it's currently designed. Service detection does exactly what you suggest: delete the calendar locally when its 404.

Maybe it is worth doing it automatically when it receives the 404 ?

There may be temporary 404s or just users who don't expect their local data to be removed automatically, even if the calendar is gone on the server. This is the reason why we made it like it currently is.

We have often thougt about running service detection periodically or when syncing, but at the end I think it's the best tradeoff between traffic, user expections and functionality as it is.

@rfc2822 rfc2822 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 16, 2024
@p1gp1g
Copy link
Author

p1gp1g commented Sep 16, 2024

Ok, it makes sense. Do you think it would be possible to add a suggestion to the user to refresh their list when it receives this 404 ? "The requested resource doesn't exist (anymore), you may want to refresh your collection list"

@rfc2822
Copy link
Member

rfc2822 commented Sep 16, 2024

Absolutely. We want more detailled error messages with suggestions for a long time ;) I added it to #887. However I don't have an idea when this will be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants