Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't upload event when calendar is "read-only" #572

Closed
devvv4ever opened this issue Feb 16, 2024 · 1 comment · Fixed by #587
Closed

Don't upload event when calendar is "read-only" #572

devvv4ever opened this issue Feb 16, 2024 · 1 comment · Fixed by #587
Assignees
Labels
bug Something isn't working

Comments

@devvv4ever
Copy link
Member

devvv4ever commented Feb 16, 2024

Use case: Users have a read-only calendar (correctly recognized by DAVx5 as read only), for instance the "Contact's birthdays" of Nextcloud. Although the calendar is read-only people may edit the some local properties like "alarm/reminders". In this case the event becomes dirty, but it must NOT be uploaded. Otherwise the server sends an error.

See also https://github.com/bitfireAT/davx5/issues/54

@devvv4ever devvv4ever added the bug Something isn't working label Feb 16, 2024
@rfc2822
Copy link
Member

rfc2822 commented Feb 19, 2024

  • Make readOnly a LocalCollectionProperty
  • Lift readOnly from ContactsSyncManager up to SyncManager,
  • set accordingly for all collection types
    • LocalAddressBook (readOnly prop existed already)
    • LocalCalendar
    • LocalJtxCollection - can't get/set readOnly prop - assuming write access for now
    • LocalTaskList
  • CalendarSyncManager:
    • uploadDirty should handle readOnly accordingly
    • processLocallyDeleted should handle readOnly accordingly

Probably correct handling for the collection types (tasks, jtx entries) would be a good idea, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants