Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateUtils.parseVTimeZone throws unexpected exception #184

Closed
rfc2822 opened this issue Nov 21, 2024 · 0 comments · Fixed by #185
Closed

DateUtils.parseVTimeZone throws unexpected exception #184

rfc2822 opened this issue Nov 21, 2024 · 0 comments · Fixed by #185
Assignees
@rfc2822
Labels
refactoring Quality improvement of existing functions

Comments

@rfc2822
Copy link
Member

rfc2822 commented Nov 21, 2024

It's dangerous that DateUtils.parseVTimeZone throws a RuntimeException when the timezone definition is unparseable (which is easily possible).

It should return null instead.
@rfc2822 rfc2822 added the refactoring Quality improvement of existing functions label Nov 21, 2024
@rfc2822 rfc2822 self-assigned this Nov 21, 2024
@rfc2822 rfc2822 linked a pull request Nov 21, 2024 that will close this issue
DateUtils.parseVTimeZone: return null instead of throwing a RuntimeException #185
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rfc2822 rfc2822

Labels
refactoring Quality improvement of existing functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DateUtils.parseVTimeZone: return null instead of throwing a RuntimeException bitfireAT/ical4android
1 participant
@rfc2822