Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torznab results are missing the link tag #349

Open
Stitch10925 opened this issue Nov 15, 2024 · 7 comments
Open

Torznab results are missing the link tag #349

Stitch10925 opened this issue Nov 15, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@Stitch10925
Copy link

  • [v] I have checked the existing issues to avoid duplicates
  • [v] I have redacted any info hashes and content metadata from any logs or screenshots attached to this issue

Describe the bug

Following the example on this page with regards to the torznab format:

Torznab Spec

There is a element inside of the element, which bitmagnet is not returning.

To Reproduce

Steps to reproduce the behavior:

Query bitmagnet via the torznab api.
For example:

<url to torznab api>?t=music&q=wuthering heights

Expected behavior

Link element to be available inside of each item element.

Environment Information (Required)

  • Bitmagnet version: 0.9.5
  • OS and version: Alpine Linux / Docker v25

Additional context

When connecting Bitmagnet as search engine for headphones, headphones fails on the missing link element.

@Stitch10925 Stitch10925 added the bug Something isn't working label Nov 15, 2024
@askiiart
Copy link

Technically speaking, this is an issue with Headphones; the Torznab spec (though flawed) doesn't list link as required, nor is it required in the RSS spec.

That being said, I don't see why this couldn't be added to Bitmagnet for compatibility sake.

@Stitch10925
Copy link
Author

Would be great if it could be added. That way headphones can be used as well.

Thanks for the reply!

@rraymondgh
Copy link
Contributor

@askiiart @Stitch10925 I've been searching for definition on link element and cannot find it. Taking an example from what bitmagnet currently produces. Should link element be the url attribute of enclosure element? Which is same as magneturl extended attribute

I'm currently doing maintenance / enhancements of torznab bitmagent interface. Happy to include this.

<?xml version="1.0" encoding="UTF-8"?>
<rss version="2.0" xmlns:atom="http://www.w3.org/2005/Atom" xmlns:torznab="http://torznab.com/schemas/2015/feed">
  <channel>
    <title>bitmagnet</title>
    <pubDate>Mon, 01 Jan 0001 00:00:00 +0000</pubDate>
    <lastBuildDate>Mon, 01 Jan 0001 00:00:00 +0000</lastBuildDate>
    <response xmlns="http://www.newznab.com/DTD/2010/feeds/attributes/"></response>
    <item>
      <title>redacted (2010) Flac</title>
      <guid>c13fe30fd524c0bb99433512d419cd8bca04a689</guid>
      <pubDate>Sun, 19 Jan 2025 11:06:28 +0000</pubDate>
      <category>music</category>
      <size>579189180</size>
      <comments>http://172.17.0.1:3336/webui/torrents/permalink/c13fe30fd524c0bb99433512d419cd8bca04a689</comments>
      <enclosure url="magnet:?xt=urn:btih:c13fe30fd524c0bb99433512d419cd8bca04a689&amp;dn=redacted+-+redacted+%282010%29+Flac&amp;xl=579189180" length="579189180" type="application/x-bittorrent;x-scheme-handler/magnet"></enclosure>
      <torznab:attr name="infohash" value="c13fe30fd524c0bb99433512d419cd8bca04a689"></torznab:attr>
      <torznab:attr name="magneturl" value="magnet:?xt=urn:btih:c13fe30fd524c0bb99433512d419cd8bca04a689&amp;dn=redacted+-+redacted+%282010%29+Flac&amp;xl=579189180"></torznab:attr>
      <torznab:attr name="category" value="3000"></torznab:attr>
      <torznab:attr name="size" value="579189180"></torznab:attr>
      <torznab:attr name="publishdate" value="Sun, 19 Jan 2025 11:06:28 +0000"></torznab:attr>
      <torznab:attr name="seeders" value="25"></torznab:attr>
      <torznab:attr name="leechers" value="7"></torznab:attr>
    </item>
  </channel>
</rss>

@askiiart
Copy link

I think link can be a link to its web UI thing, and if not, then a link to the torrent file or the magnet URI (i.e. the same as the url attribute of the enclosure element); not 100% sure about that first bit, but I'm 100% sure about the torrent file and magnet URI.

As for Newznab, again I'm not entirely sure if the web UI thing is okay, but I can confirm that link being the same as the url in the enclosure element works right, as seen here.

@askiiart
Copy link

Though after a tad more thought, given Headphones requires link, my guess would be that link should be the torrent file or magnet URI.

@rraymondgh
Copy link
Contributor

rraymondgh commented Jan 20, 2025

Thanks - I don't have a way to test really. If I provide you with a branch with change can you build and test? When you refer to headphones do you mean this: https://github.com/rembo10/headphones?tab=readme-ov-file ? At quick glance there is no docker image for it...

@Stitch10925
Copy link
Author

@rraymondgh
Thanks for adding this in!

The docker image is this one:
https://hub.docker.com/r/linuxserver/headphones/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants