-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration path from stable/airflow to bitnami/airflow #3580
Comments
Thanks for creating this issue @scottrigby, we are happy to investigate a migration path from the current stable to the bitnami one, adding the features/examples/docs whatever is missing to make a smooth transition. Regarding the 2nd day maintenance, we already have some charts in our repository contributed from community users like #2072, that means we are happy to work together on adding more charts to our catalog (this time it is not an addition but a major refactor) and also providing support, updates, etc. Everything related to the chart support is handled publicly in GitHub via issues and PRs, just the tests and release process is done outside GitHub (in our internal CI/CD pipeline in this case). Having said that, we look forward to hearing how we can collaborate with current maintainers to carry out this migration successfully (if you prefer this path, of course). |
To be frank, the current What we need is a place to host it after November (when helm 2 goes away). After November, we would likely maintain the existing chart until the offical airflow helm chart is feature complete and stable enough for widespread use. Given you guys have release infrastructure already setup, it would be awesome if we could simply lift and shift into your repository (seperate from your existing chart of course). This saves lots of hassle on both user/dev side, especially since users will have to migrate to the official chart at some point anyway. If this is not possible, no worries, I expect we will be able to find another place to host it. |
@thesuperzapper charts within a helm repo must have unique names, so to make what you're recommending work the chart would have to be renamed before being added. Wouldn't it be better to merge any missing features from stable/airflow into bitnami/airflow? If you'd like help splicing in history from stable I could give it a shot, though I may need your help correctly reconciling conflicts, since you're intimately familiar with this chart as a maintainer. Like you said you could alternatively host it anywhere else - under your own GitHub user for example. But it seems there's willingness to make a fruitful collaboration here. To me it seems that might ultimately be the best case scenario for end users. |
Given the among of history behind the stable/airflow chart, I am not sure the git history approach is realistic. I (maybe @thesuperzapper as well) simply cannot tell you right away what are the features difference with the bitnami chart. I am not even sure the difference is that there would be only "missing" features on the bitnami chart, from what I see it looks like more complex, maybe more complete, take a slightly different approach on things like DAG propagation, etc, and aligning both may not even make any sense. "stable/airflow" is like it is, a big baby that works in production. Our top priority is that we would like to see it alive after November. But it it really important to decouple both problematics. Personally, because life is life and Airflow stuff does not feed the family, sadly, I do not have time and even the will to take the risk of aligning our chart with the bitnami chart + write and verify the migration guide + handle all use cases that will arise from this (big) change. I stick to our proposal:
|
@scottrigby @gsemet I really don't mind if it needs to be renamed, but I am much more comfortable having the chat move as-is given how many people are using it in production. So that leaves us with 3 options:
|
@carrodher are any of these options acceptable to you? |
From the Bitnami POV, there are only three requirements to add a new chart to the catalog:
IMHO the 2nd option is not easy to follow as you will need to meet the above requirements in order to add the chart to the bitnami catalog, although named About the 1st option, the already existing |
@scottrigby my thoughts
|
I think it will be better to let the different charts live their life independently, I see too many blockers to have a smooth migration about users of current We realy want to ease migration and so we will clearly point to the other charts, and even try to make the community create migration guides or something like this. But we don't know the bitnami chart as of today, how hard or easy it would be to change the docker image, adapt the process etc. And the among of test required to ensure it will not break somewhere is not feasible for us. For me, from the outside, it looks like the bitnami chart is a bit too far from what we have now in stable/airflow, so let's keep different charts and let the community use whatever they want. |
Yes, it makes sense. From our point of view, we are happy to integrate the chart here if needed, but in the end, this is not a decision on our side, if you find it easy following a different path is fine. If finally, you consider integrating the existing chart into the Bitnami catalog following the mentioned process, we can help with that. |
This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback. |
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary. |
Which chart:
bitnami/airflow
Is your feature request related to a problem? Please describe.
There isn't urgently a clear migration path from stable/airflow to another well maintained airflow chart.
Describe the solution you'd like
@carrodher said it would be great if the current maintainers/contributors would be willing to help, and would be happy to work together on creating this migration path and moving the missing features.
Describe alternatives you've considered
A chart hosted in the airflow org. See apache/airflow#10523
Additional context
As I understand it, on the Bitnami side the only requirement for the charts is that the default images need to be bitnami images in the main chart and subcharts, for example in this case, redis & postgresql. However, there are some charts like PostgreSQL where although the default images are the bitnami ones, it is easily replaced by another postgresql images just using --set image.repository=whatever.
The text was updated successfully, but these errors were encountered: