-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable/redis] Making chart deployment HA with Sentinels? #856
Comments
I have my concerns with this. Basically when the a slave gets promoted to master. How will the k8s services point to the correct master? At the moment, the solution that redis-ha proposes is to have some logic in the container that talks to the kubernetes API server and updates the labels accordingly. I am not very convinced by this approach as it is a bit obscure. That's the main reason we prefer using the native kubernetes failover solution in the @prydonius @sameersbn what's your take on this? |
I just to be clear, I wasn't referring to "stable" redis-ha chart as a direction to go but incubator/redis-cache chart. Also, do you @javsalgar think stable/redis failover is absolutely the best possible approach to the problem? In fact, when I look into stable/redis chart it's totally unclear how it handles failover. UPDATE: The web deserves this! :) |
Hi, I did not know about |
It doesn't need this be micro per se, it can be literally anything thats puvlic and vetted as far as I'm concerned. Any other thoughts? |
Ping @prydonius @sameersbn |
This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback. |
This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback. |
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary. |
PR helm/charts#13112 should cover your use case |
This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback. |
@pentago could you confirm that helm/charts#13112 is what you were looking for? |
Looks like it but since asking this I used official redis chart which has failover option. Not sure how these two compare but will test when I get some time. Thanks! |
Let us know any feedback you have :) |
This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback. |
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary. |
Any chance the stable/redis chart can be refactored to provide genuine HA setup with Redis Sentinels (proper failover and slave promotion to master nodes)?
Official stable/redis-ha chart isn't working properly, it's not very production-friendly and PRs are merged at quite slow pace.
I think plenty of people would prefer Bitnami-built Redis HA chart with customizable persistence, unlike incubator/redis-cache chart which does Sentinels but not persistence too (this is a big deal for lots of deployments and companies). This chart could be used as a starting poing I guess.
Thanks in advance and looking forward to hearing opinions.
The text was updated successfully, but these errors were encountered: