Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parseModels and parseModel to fix duplicate instances being created after create an update. #571

Closed
wants to merge 8 commits into from

Conversation

justinbmeyer
Copy link
Contributor

This fixes this bug while still maintaining backwards compatibility. This introduces parseModel and parseModel methods that are called by update and create, which keeps #301. If they are provided, they will be used over a provided model and models method.

This is documented with newly added @deprecated tags in DocumentJS. @tomgreever should make sure the styles look right before we launch.

This is for 2.1 because it deprecates some of model and models functionality.

@justinbmeyer
Copy link
Contributor Author

I'm going to merge this into minor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant