Fixes nested components and <content> tags.
#619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daffl
added a commit
that referenced
this pull request
Dec 19, 2013
…rflow-bug Fixes nested components and `<content>` tags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As identified by #549, this fixes a bug with nested content tags by:
Making sure helpers are passed the same way as scope. Essentially parent helpers were not available. 586520c#diff-9ede961af024a842ba5e956318112b39R238 This was a bug waiting to be found.
Changing scanner to look all the way to content: 586520c#diff-08e58b9c9e7b5aea7a452a3e45ca998fR190. This would previously stop once it found a tags object, I needed it to keep going if it didn't find the actual matching tag.
Then I temporarily remove the tag.content callback while rendering the content. 586520c#diff-9ede961af024a842ba5e956318112b39R222 This is the core problem, that if you were rendering a
<content>s content that had another<content>within it, it would keep rendering the parent content. By deleting it, and changing scanner, scanner will go to the previous parent's content tag callback.