-
Notifications
You must be signed in to change notification settings - Fork 33
Conversation
The error is:
Did the size of NDK grow significantly since 13? In any case, thank you for the PR and we'll try to check why there's not enough space for the new NDK ASAP |
Yes, it grown:
|
Thanks @koral-- ! We'll try to review this and push it through ASAP, but it most likely won't be a part of this weekend's update, only next week's - the update images are created in less than 24 hours, so that we can run tests with them on Friday (and fix anything if required) before the deploy on Saturday. |
We increased storage/disk space on the Linux/Android stack, re-run of the PR was successful with the increased storage. Schedule: We'll merge this PR next week, and will be part of next weekend's updates! |
Perfect, re-build success and all tests passed - will be part of this weekend's updates. Thanks again for the PR @koral-- ! ;) |
Could you please add this change to the CHANGELOG? |
I'm not sure who should update a CHANGELOG and whether version number is correct (I've used date of merge). If PR authors should do it, there should be such information in REDAME perhaps. BTW it seems that tag for this change is also missing and there is no release for current latest tag: https://github.com/bitrise-docker/android-ndk/releases |
Ohh, you're right @koral-- we forgot to tag it here; I'll do that ASAP! it's less important to mark releases here for our docker images as the tags on docker hub are completely separate ones, mainly because we do scheduled builds (alphas are rebuilt every day, pinned ones once a week when every test passes on the specified alpha). But in any case I'll do the README and tag update ASAP, thanks for the reminder! |
Done, CHANGELOG merged from #49 and tag added to the repo too - thanks again @koral-- for all the contribution, and thanks @jfirebaugh for the reminder! |
No description provided.