New API: get transaction hex without signatures field

[abitmore]

User Story
As a node API user I want features:

• get hex of a signed transaction (which is current behavior of get_transaction_hex API, if there is no signature in the transaction, there will be a byte with value 00 at the end of the hex);
• get hex of a transaction without signatures (actually without the signature field), so I can sign it directly.

Additional Context
I've heard of complaints from different people about the extra 00 byte returned by get_transaction_hex API. Not sure how that API is being used by client software, so IMHO it's safer to keep its behavior and add a new API (although don't know whether/how the new API will be used as well).

CORE TEAM TASK LIST

• Evaluate / Prioritize Feature Request
• Refine User Stories / Requirements
• Define Test Cases
• Design / Develop Solution
• Perform QA/Testing
• Update Documentation

[windycrypto]

I am working on multi-sig function of cli_wallet these days, may I take this issue two? @ryanRfox

[oxarbitrage]

i will say yes. @ryanRfox please make @cifer-lee part of the bitshares organization so we can assign him issues.

[ryanRfox]

Yes @cifer-lee Thank you for claiming this Issue. I have added to the Communit Claims board and marked it In Development. Next, @oxarbitrage I will reach out to @abitmore to add @cifer-lee to the Organization (I don't have access to perform that task).

[abitmore]

@ryanRfox I've invited @cifer-lee. Write permission will be granted after some time.

[windycrypto]

Thanks Alfredo, Fox and Abit~

[windycrypto]

Seems this can be solved by static_casting signed_transaction to transaction when packing.

---

For curious, the tail 00 was cause by line 565 of the packing code:

// libraries/fc/include/fc/io/raw.hpp

561     template<typename Stream, typename T>
562     inline void pack( Stream& s, const std::vector<T>& value, uint32_t _max_depth ) {
563        FC_ASSERT( _max_depth > 0 );
564        --_max_depth;
565        fc::raw::pack( s, unsigned_int((uint32_t)value.size()), _max_depth );
566        auto itr = value.begin();
567        auto end = value.end();
568        while( itr != end ) {
569           fc::raw::pack( s, *itr, _max_depth );
570           ++itr;
571        }
572     }

When packing a vector object(as signed_transaction::signatures be), the size will go in first, and as less bytes as the value can be hold.

[oxarbitrage]

closed by #1038