Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset Details (collateral, settled volume) #1448

Closed
startailcoon opened this issue Nov 25, 2018 · 6 comments
Closed

Asset Details (collateral, settled volume) #1448

startailcoon opened this issue Nov 25, 2018 · 6 comments

Comments

@startailcoon
Copy link

Related to issue bitshares/bitshares-ui#1119, we're adding more details to the Bitshares Asset page.

The details that I miss on-chain is

  • Total asset collateral
  • Total settled volume in maintenance interval

Can we somehow include these two in the asset data object, we could make the details page much more detailed.

@abitmore
Copy link
Member

Total asset collateral

This data is not directly available in bitshares-core so far. It's sum of collateral of all debt positions.

Total settled volume in maintenance interval

get_object 2.4.21
   "force_settled_volume": 0, 

@oxarbitrage
Copy link
Member

should we use this issue to build database api call: total_asset_collateral(string asset_id_or_name) ?

@abitmore
Copy link
Member

If we really want the data, IMHO the best way is to add a field in asset_bitasset_data and update it every time when a debt position got updated. However, it's not consensus data, so I'm not sure if it worth the efforts. Perhaps use a plugin to track the data? Anyway, if add an API call, it's not ideal to sum on the fly.

@startailcoon
Copy link
Author

startailcoon commented Nov 25, 2018

What I see, we only need total collateral for

black swan price: MSSR * debt / collateral, if feed price is below this value, a black swan event may occur

or if we wish to display the total in some fancy way.

If this information isn't possible to maintain in any other way, or if it's not something we find important to show, we don't need this.

@abitmore
Copy link
Member

abitmore commented Nov 26, 2018

@startailcoon black swan price is calculated from collateral amount of the debt position with least collateral ratio (but not the total collateral of all debt positions), which should be the first item in result of get_call_orders API.

@startailcoon
Copy link
Author

We could close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants