Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting delayed_node creates unusable config.ini #1986

Closed
1 of 17 tasks
jmjatlanta opened this issue Sep 11, 2019 · 4 comments
Closed
1 of 17 tasks

Starting delayed_node creates unusable config.ini #1986

jmjatlanta opened this issue Sep 11, 2019 · 4 comments

Comments

@jmjatlanta
Copy link
Contributor

Bug Description
Starting delayed_node with no previous config.ini will create one with all data within duplicated.

Impacts
Describe which portion(s) of BitShares Core may be impacted by this bug. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

Steps To Reproduce
Start delayed_node with config.ini missing

Expected Behavior
A default config.ini is created that is usable

Screenshots (optional)

~/Development/cpp/bitshares-core/build$ ./programs/delayed_node/delayed_node 
1862781ms th_a       main.cpp:122                  main                 ] Writing new config file at /home/jmjatlanta/Development/cpp/bitshares-core/build/delayed_node_data_dir/config.ini
1862782ms th_a       main.cpp:206                  main                 ] Exiting with error:
13 N5boost16exception_detail10clone_implINS0_19error_info_injectorINS_13property_tree10ini_parser16ini_parser_errorEEEEE: /home/jmjatlanta/Development/cpp/bitshares-core/build/delayed_node_data_dir/config.ini(167): duplicate key name
/home/jmjatlanta/Development/cpp/bitshares-core/build/delayed_node_data_dir/config.ini(167): duplicate key name: 
    {"what":"/home/jmjatlanta/Development/cpp/bitshares-core/build/delayed_node_data_dir/config.ini(167): duplicate key name"}
    th_a  main.cpp:315 load_logging_config_from_ini_file

Host Environment
Please provide details about the host environment. Much of this information can be found running: witness_node --version.

  • Host OS: Ubuntu 18.04 LTS
  • Host Physical RAM 64GB
  • BitShares Version: develop
  • OpenSSL Version: 1.1.1
  • Boost Version: 1.68

CORE TEAM TASK LIST

  • Evaluate / Prioritize Bug Report
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@jmjatlanta
Copy link
Contributor Author

Code for delayed_node looks very similar to witness_node, but generates different results. I am still investigating.

@abitmore
Copy link
Member

abitmore commented Sep 11, 2019

If delayed_node is unusable but nobody complained, I think it's a good time to deprecate it now. People who need the features should run witness_node --plugins delayed_node.

@abitmore abitmore added this to the 4.1.0 - Feature Release milestone Sep 11, 2019
@pmconrad
Copy link
Contributor

I suppose it is still usable in existing installations. New installations hopefully won't use it.
I've left it out of the gitian build, so far nobody has complained.
I've thought about replacing the binary with a wrapper script, but it gets complicated with the "--plugins" option.

@abitmore
Copy link
Member

Fixed by #1988.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants